tx_signer: fix retry-on-error behavior #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #181 +/- ##
===========================================
- Coverage 22.77% 22.72% -0.05%
===========================================
Files 63 63
Lines 2450 2455 +5
===========================================
Hits 558 558
- Misses 1892 1897 +5
Continue to review full report at Codecov.
|
Fixes the logic to retry failed transactions at a higher sequence number if the previous attempts to broadcast a transaction resulted in an error. Prior to this commit, the logic was never triggered as it needed to store whether or not the prior transaction succeeded before performing a new one.
tarcieri
force-pushed
the
fix-tx-retries-on-error
branch
from
3e89ae7
to
90836b5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the logic to retry failed transactions at a higher sequence number if the previous attempts to broadcast a transaction resulted in an error.
Prior to this commit, the logic was never triggered as it needed to store whether or not the prior transaction succeeded before performing a new one.