Remove signatory; vendor signatory-ledger-tm under ledger feature
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in iqlusioninc/signatory#71, this commit removes the remaining dependencies on Signatory in favor of directly integrating the last remaining Signatory-based provider, `signatory-ledger-tm`, which was vendored from code as of this commit: https://github.com/iqlusioninc/signatory/tree/4110887/signatory-ledger-tm It also renames the feature to simply `ledger`, so it can be gated on the `ledger` crate dependency.
tarcieri
force-pushed
the
remove-signatory-vendor-ledgertm
branch
from
7180305
to
6180ffb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in iqlusioninc/signatory#71, this commit removes the remaining dependencies on Signatory in favor of directly integrating the last remaining Signatory-based provider,
signatory-ledger-tm, which was vendored from code as of this commit:https://github.com/iqlusioninc/signatory/tree/4110887/signatory-ledger-tm
It also renames the feature to simply
ledger, so it can be gated on theledgercrate dependency.