Add Persistence config #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fails some tests, so I'll fix it first. |
Codecov Report
@@ Coverage Diff @@
## main #373 +/- ##
==========================================
- Coverage 20.23% 20.22% -0.01%
==========================================
Files 73 73
Lines 2743 2749 +6
==========================================
+ Hits 555 556 +1
- Misses 2188 2193 +5
Continue to review full report at Codecov.
|
|
Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aaaand another config.
This is a bit tricky as the chain_id doesn't match the network name (chain id is core-1, network name is persistence, bech prefix are persistencesomething), still should work though.
I'll also ask somebody from the Persistence foundation to review this.