Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot mode (+B) #439

Merged
merged 5 commits into from
Apr 12, 2021
Merged

Bot mode (+B) #439

merged 5 commits into from
Apr 12, 2021

Conversation

DanielOaks
Copy link
Member

@DanielOaks DanielOaks commented Feb 25, 2021

This specification defines the Bot mode, ISUPPORT token and WHO flags which are already in use by a number of IRC servers. It also defines the bot tag, which is in use as a vendor tag by InspIRCd right now (as inspircd.org/bot).

Short, sweet, simple. Mostly explains existing behaviour apart from that bot tag, and I don't really feel like it's necessary to go through the whole draft/ prefix for six months stage for something which is a simple tag like this.

Discussion happened in ircv3/ircv3-ideas#43 and servers implemented and converged on this behaviour (apart from the tag) during that discussion.

extensions/bot-mode.md Outdated Show resolved Hide resolved
@SadieCat
Copy link
Contributor

LGTM. :shipit:

@jwheare
Copy link
Member

jwheare commented Feb 27, 2021

Don't see a strong reason for the draft/ to be skipped here.

@jwheare
Copy link
Member

jwheare commented Feb 27, 2021

Referring to the tag specifically. The other stuff is already out there in the wild.

@progval
Copy link
Contributor

progval commented Feb 27, 2021

Also, mention that server mustn't/shouldn't send a value to the tag, but clients should ignore the value if any. (same reasons as usual)

@SadieCat
Copy link
Contributor

It might be a good idea to require the WHO flag to be the same as the value specified in the BOT isupport token? That way if a server implementation is already using B as a status rank they won't confuse any clients. This idea would be compatible with all existing server implementations afaik.

@DanielOaks
Copy link
Member Author

Alright, will change it to draft/bot and we could make the WHO flag be the same value I guess? requires a bit more work on clients' side but if it makes it more flexible in a way that makes sense and conforms with all current impls then sure why not.

@DanielOaks
Copy link
Member Author

DanielOaks commented Feb 28, 2021

I'd be interested in another few devs sanity-checking/commenting on the bdf5f5a change, but yeah I'm pretty satisfied with this now after the changes.

progval added a commit to progval/Limnoria that referenced this pull request Feb 28, 2021
It is enabld by default in order to be a good netizen,
but can be overridden by admins if needed.

References:
*
* ircv3/ircv3-specifications#439
@SadieCat
Copy link
Contributor

Is there anything blocking this?

@jwheare
Copy link
Member

jwheare commented Mar 13, 2021

LGTM

slingamn added a commit to slingamn/ergo that referenced this pull request Mar 17, 2021
Implement the new bot mode spec:
ircv3/ircv3-specifications#439
@DanielOaks DanielOaks merged commit b1664ee into ircv3:master Apr 12, 2021
pbui added a commit to pbui/bobbit that referenced this pull request May 7, 2021
emersion added a commit to emersion/soju that referenced this pull request May 24, 2021
@slingamn
Copy link
Contributor

Let's take a census of implementations so we can ratify this? It sounds like this has at least two server implementations (Ergo, Inspircd) and at least two client implementations (Limnoria, Bobbit).

@progval
Copy link
Contributor

progval commented May 31, 2021

Limnoria sets the bot mode, and IRCCloud uses the bot tag. According to https://ircv3.net/software/clients.html , BitBot doesn't set the mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants