Add Attention Test Suite #37
Conversation
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
| # query_type;key_type;value_type;scale_type | ||
| type_and_layout_combinations=( | ||
| "f16;f16;f16;f16" | ||
| ) |
There was a problem hiding this comment.
Want to test other combinations? What could we test?
Generally, the test suite can and should include tests that don't currently pass.
There was a problem hiding this comment.
The current test suite has not supported yet the other combinations. It will support; however, it needs some discussions - that is one of my upcoming tasks.
| # Generates a test function in the generated MLIR code. | ||
| # The generated function will take the same arguments as iree_linalg_ext.attention variants | ||
| # and will just call iree_linalg_ext.attention variants with them, returning its result. | ||
| def generate_function( |
There was a problem hiding this comment.
Bringing back some discussion from iree-org/iree#17751 (comment), could this generator produce operations other than iree_linalg_ext.attention? Fine to start with only that one, but what about iree_linalg_ext.online_attention or even torch.nn.functional.scaled_dot_product_attention?
There was a problem hiding this comment.
Better to ask this Kunwar @Groverkss.
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Progress on this #2
This PR refactors, adds, and migrates Attention e2e tests from the PR here: iree-org/iree#18320