-
Notifications
You must be signed in to change notification settings - Fork 603
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The method used in op_kernels_fft.h should be resize, not reserve. reserve() does not modify the size variable in a vector, which causes undefined-behavior. Also adapt the RFFT python tests to e2e/xla_ops lit tests. The input and expected output are derived from python tests. note: I gave it a shot to IRFFT, but it did not work. And the purpose is to decouple testing from python for #5299, so this change focus on RFFT support.
- Loading branch information
Showing
6 changed files
with
30 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// TODO(hanchung): Add other types of fft tests, e.g. fft, ifft, irfft. | ||
|
||
func @rfft_real() attributes { iree.module.export } { | ||
%input = iree.unfoldable_constant dense<[ | ||
9.0, 1.0, 4.5, -0.3, 10.0, -1.0, 5.5, 0.3, 299.0, 3.5, -0.777, 2.0, 1.7, | ||
3.5, -4.5, 0.0, 9.0, 1.0, 4.5, -0.3, 10.0, -1.0, 5.5, 0.3, 299.0, 3.5, | ||
-0.777, 2.0, 1.7, 3.5, -4.5, 0.0]> : tensor<32xf32> | ||
%0 = "mhlo.fft"(%input) { | ||
fft_length = dense<32> : tensor<1xi64>, fft_type = "RFFT" | ||
} : (tensor<32xf32>) -> tensor<17xcomplex<f32>> | ||
%real = "mhlo.real"(%0) : (tensor<17xcomplex<f32>>) -> tensor<17xf32> | ||
check.expect_almost_eq_const(%real, dense<[666.8460, 0.0, -590.16925, 0.0, 593.4485, 0.0, -579.52875, 0.0, 629.95404, 0.0, -567.1126, 0.0, 591.75146, 0.0, -583.1894, 0.0, 630.846]> : tensor<17xf32>) : tensor<17xf32> | ||
return | ||
} | ||
|
||
func @rfft_imag() attributes { iree.module.export } { | ||
%input = iree.unfoldable_constant dense<[ | ||
9.0, 1.0, 4.5, -0.3, 10.0, -1.0, 5.5, 0.3, 299.0, 3.5, -0.777, 2.0, 1.7, | ||
3.5, -4.5, 0.0, 9.0, 1.0, 4.5, -0.3, 10.0, -1.0, 5.5, 0.3, 299.0, 3.5, | ||
-0.777, 2.0, 1.7, 3.5, -4.5, 0.0]> : tensor<32xf32> | ||
%0 = "mhlo.fft"(%input) { | ||
fft_length = dense<32> : tensor<1xi64>, fft_type = "RFFT" | ||
} : (tensor<32xf32>) -> tensor<17xcomplex<f32>> | ||
%imag = "mhlo.imag"(%0) : (tensor<17xcomplex<f32>>) -> tensor<17xf32> | ||
check.expect_almost_eq_const(%imag, dense<[0.0, 0.0, -23.956373, 0.0, -10.254326, 0.0, -6.1443653, 0.0, -10.0, 0.0, 3.865515, 0.0, 0.63767385, 0.0, 52.453506, 0.0, 0.0]> : tensor<17xf32>) : tensor<17xf32> | ||
return | ||
} |