Skip to content

Commit

Permalink
Turn vectorization on by default for linalg on tensors path (#5280)
Browse files Browse the repository at this point in the history
  • Loading branch information
antiagainst authored Apr 1, 2021
1 parent 894dac6 commit 9cd93ba
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ SPIRVCodegenOptions getSPIRVCodegenOptionsFromClOptions() {
options.workgroupSize.assign(clWorkgroupSizes.begin(),
clWorkgroupSizes.end());
options.tileSizes.assign(clTileSizes.begin(), clTileSizes.end());
options.enableVectorization = clEnableVectorization;
options.enableVectorization =

This comment has been minimized.

Copy link
@MaheshRavishankar

MaheshRavishankar Apr 1, 2021

Contributor

Why are there two flags to do this. Can we make this one flag please?

This comment has been minimized.

Copy link
@antiagainst

antiagainst Apr 1, 2021

Author Contributor

Not sure I follow exactly. Both are existing flags. One for controlling whether to turn on linalg on tensors path. Another for turning on vectorization. To kill either one we need to deprecate the linalg on buffers path first, right?

This comment has been minimized.

Copy link
@MaheshRavishankar

MaheshRavishankar Apr 1, 2021

Contributor

Ah, I didnt know we had another flag for vectorization on the tensors path. Would not have expected that.

This comment has been minimized.

Copy link
@MaheshRavishankar

MaheshRavishankar Apr 1, 2021

Contributor

SOrry, totally misread the flag here. Now it makes sense

clEnableLinalgOnTensorsSPIRV || clEnableVectorization;
options.useWorkgroupMemory = clUseWorkgroupMemory;
options.vectorizeMemref = clVectorizeMemref;
options.usingLinalgOnTensors = clEnableLinalgOnTensorsSPIRV;
Expand Down

0 comments on commit 9cd93ba

Please sign in to comment.