Skip to content

Commit

Permalink
Enable some now-passing HAL CTS tests. (#11537)
Browse files Browse the repository at this point in the history
Context:
* #8334
* #4680
  • Loading branch information
ScottTodd authored Jan 4, 2023
1 parent e81ae5f commit c8ee571
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 17 deletions.
10 changes: 2 additions & 8 deletions runtime/src/iree/hal/drivers/cuda/cts/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,7 @@ iree_hal_cts_test_suite(
DEPS
iree::hal::drivers::cuda::registration
EXCLUDED_TESTS
# This test depends on iree_hal_cuda_stream_command_buffer_update_buffer
# via iree_hal_buffer_view_allocate_buffer, which is not implemented yet.
"command_buffer_dispatch"
# Semaphores are not implemented in the CUDA backend yet.
"semaphore_submission"
# Semaphores are not fully implemented in the CUDA backend yet.
"semaphore"
)

Expand All @@ -46,7 +42,5 @@ iree_hal_cts_test_suite(
iree::hal::drivers::cuda::registration
INCLUDED_TESTS
"command_buffer"
# This test depends on iree_hal_cuda_stream_command_buffer_update_buffer
# via iree_hal_buffer_view_allocate_buffer, which is not implemented yet.
# "command_buffer_dispatch"
"command_buffer_dispatch"
)
12 changes: 3 additions & 9 deletions runtime/src/iree/hal/drivers/local_sync/cts/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,8 @@ if(IREE_HAL_EXECUTABLE_LOADER_EMBEDDED_ELF)
DEPS
iree::hal::drivers::local_sync::registration
EXCLUDED_TESTS
# TODO(#4680): command buffer recording so that these can run on sync HAL
"command_buffer"
"event"
"semaphore_submission"
)
"semaphore_submission" # SubmitWithWait hangs?
)
endif()

if(IREE_HAL_EXECUTABLE_LOADER_VMVX_MODULE)
Expand All @@ -52,9 +49,6 @@ if(IREE_HAL_EXECUTABLE_LOADER_VMVX_MODULE)
DEPS
iree::hal::drivers::local_sync::registration
EXCLUDED_TESTS
# TODO(#4680): command buffer recording so that these can run on sync HAL
"command_buffer"
"event"
"semaphore_submission"
"semaphore_submission" # SubmitWithWait hangs?
)
endif()

0 comments on commit c8ee571

Please sign in to comment.