Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VMVX] Switch to new pass generation tablegen definitions #18149

Merged
merged 2 commits into from
Aug 8, 2024
Merged

[VMVX] Switch to new pass generation tablegen definitions #18149

merged 2 commits into from
Aug 8, 2024

Conversation

hanhanW
Copy link
Contributor

@hanhanW hanhanW commented Aug 8, 2024 •
edited
Loading

This should be NFC. The additional changes:

  • Removes an unused using-declaration from VMVXLowerExecutableTargetPass.
  • Rename LowerLinalgMicrokernels.cpp to match the pass name (i.e., it becomes VMVXLowerLinalgMicrokernels.cpp).

@hanhanW
[VMVX] Switch to new pass generation tablegen definitions
272a811 
This should be NFC. The additional changes:

- Removes an unused using-declaration from VMVXLowerExecutableTargetPass.
- Rename LowerLinalgMicrokernels to match the pass name.

Signed-off-by: hanhanW <[email protected]>
@hanhanW hanhanW requested a review from benvanik August 8, 2024 00:29
MaheshRavishankar
MaheshRavishankar approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@MaheshRavishankar MaheshRavishankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two down!!

@hanhanW hanhanW merged commit 4bea50e into iree-org:main Aug 8, 2024
44 checks passed
@hanhanW hanhanW deleted the vmvx-pass-cleanup branch August 8, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaheshRavishankar MaheshRavishankar MaheshRavishankar approved these changes

@benvanik benvanik Awaiting requested review from benvanik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanhanW @MaheshRavishankar