Adding split iree_hal_buffer_prepare_map_range/commit_map_range. #18159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for the validation/offsetting/etc that acts only on metadata to occur separate from the actual commit of the mapping where the host storage is accessed. Code that wants to validate early (such as during command buffer recording) can now do so on uncommitted buffers and have a fast-path for when the underlying storage is available.
ScottTodd
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the validation/offsetting/etc that acts only on metadata to occur separate from the actual commit of the mapping where the host storage is accessed. Code that wants to validate early (such as during command buffer recording) can now do so on uncommitted buffers and have a fast-path for when the underlying storage is available.
This will be used for native implementations of reusable command buffers by allowing them to validate direct and indirect bindings during recording even if the bindings are of uncommitted buffers (#18158) that won't be available until execution-time.