Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up GPU executable flatbuffers prior to a larger reworking. #18208

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Cleaning up GPU executable flatbuffers prior to a larger reworking. #18208

merged 6 commits into from
Aug 14, 2024

Commits on Aug 13, 2024

  1. Fixing some incorrect TODOs referencing #18154.

    @benvanik
    benvanik committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3d5d652 View commit details
    Browse the repository at this point in the history

  2. Fixing ROCM/CUDA BlockSizeDef -> BlockSize. 

    (tables have Def, structs don't)
    @benvanik
    benvanik committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    8794c92 View commit details
    Browse the repository at this point in the history

  3. Renaming Metal kernel_library -> executable. 

    It's a HAL executable and will contain multiple kernel libraries.
    @benvanik
    benvanik committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    39fd06f View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Factoring out common debug info from GPU executable flatbuffers. 

    This also adds source file publishing to all GPU targets. Basic support
for export-specific debug info is added but switching targets to use it
is left to a future change.
    @benvanik
    benvanik committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d938c71 View commit details
    Browse the repository at this point in the history

  2. Renaming rocm executable -> hip executable.

    @benvanik
    benvanik committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    81ad118 View commit details
    Browse the repository at this point in the history

  3. Renaming [spirv|wgsl]_executable_def to [vulkan|webgpu]. 

    I don't expect us to have the same flatbuffers for different HAL
implementations and do expect us to have alternative file formats for
the same HAL implementation.
    @benvanik
    benvanik committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ab732ab View commit details
    Browse the repository at this point in the history