[Codegen][SME] Recognize transposed output indexing map as transpose #18369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacDue
requested review from
c-rhodes
and removed request for
MaheshRavishankar and
hanhanW
This restores the SME transpose lowering after iree-org#18074, which swapped around the indexing maps (making the input identity and the output a permutation). Signed-off-by: Benjamin Maxwell <[email protected]>
c-rhodes
reviewed
Aug 27, 2024
MaheshRavishankar
approved these changes
Aug 28, 2024
banach-space
added a commit
to banach-space/iree
that referenced
this pull request
Aug 30, 2024
I've just landed an update for the affected test (see iree-org#18369), but unfortunately forgot to re-base after the recent changes to HAL by Ben, see iree-org#18366 and iree-org#18154. This simply updates the test to align with the recent changes to HAL.
banach-space
added a commit
to banach-space/iree
that referenced
this pull request
Aug 30, 2024
I've just landed an update for the affected test (see iree-org#18369), but unfortunately forgot to re-base after the recent changes to HAL by Ben, see iree-org#18366 and iree-org#18154. This simply updates the test to align with the recent changes to HAL. Signed-off-by: Andrzej Warzynski <[email protected]>
|
Sorry, should've re-based before merging this one. Here's a fix for the test: |
josemonsalve2
pushed a commit
to josemonsalve2/iree
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the SME transpose lowering after #18074, which swapped around the indexing maps (making the input identity and the output a permutation).