Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ci_linux_arm64_clang to new dockerfile. #18569

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented Sep 20, 2024

Progress on #15332. This was the last active use of build_tools/docker/, so we can now delete that directory: #18566.

This uses the same "cpubuilder" dockerfile as the x86_64 builds, which is now built for multiple architectures thanks to iree-org/base-docker-images#11. As before, we install a qemu binary in the dockerfile, this time using the approach in iree-org/base-docker-images#13 instead of a forked dockerfile.

Prior PRs for context:

Build time varies pretty wildly depending on cache hit rate and the phase of the moon:

Scenario Cache hit rate Time Logs
Cold cache 0% 1h45m Logs
Warm (?) cache 61% 48m Logs
Warm (hot?) cache 98% 16m Logs

CI history (https://github.com/iree-org/iree/actions/workflows/ci_linux_arm64_clang.yml?query=branch%3Amain) shows that regular 97% cache hit rates and 17 minute job times are possible. I'm not sure why one test run only got 61% cache hits. This job only runs nightly, so that's not a super high priority to investigate and fix.

If we migrate the arm64 runner off of GCP (#18238) we can further simplify this workflow by dropping its reliance on gcloud auth application-default print-access-token and the docker_run.sh script. Other workflows are now using source setup_sccache.sh and some other code.

@ScottTodd ScottTodd added the infrastructure Relating to build systems, CI, or testing label Sep 20, 2024
@ScottTodd
Copy link
Member Author

Phew, the workflow run on this PR got 98% cache hits. My prior test only got 61%. Updated the table in the PR description.

@ScottTodd ScottTodd merged commit 51329bf into main Sep 23, 2024
44 checks passed
@ScottTodd ScottTodd deleted the users/scotttodd/ci-arm64 branch September 23, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Relating to build systems, CI, or testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants