CDNA1/2 data tiling #19100
Merged
CDNA1/2 data tiling #19100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjacob
force-pushed
the
users/bjacob/cdna1-cdna2-data-tiling
branch
from
d7bd67a
to
e335ba2
Compare
bjacob
force-pushed
the
users/bjacob/more-mma-intrinsics
branch
from
50c222c
to
ffc4d58
Compare
bjacob
force-pushed
the
users/bjacob/cdna1-cdna2-data-tiling
branch
from
e335ba2
to
58beb25
Compare
bjacob
force-pushed
the
users/bjacob/more-mma-intrinsics
branch
from
ffc4d58
to
09d91a5
Compare
bjacob
force-pushed
the
users/bjacob/cdna1-cdna2-data-tiling
branch
from
58beb25
to
a89bc41
Compare
Signed-off-by: Benoit Jacob <[email protected]>
bjacob
force-pushed
the
users/bjacob/more-mma-intrinsics
branch
from
09d91a5
to
ab2aa4c
Compare
Signed-off-by: Benoit Jacob <[email protected]>
bjacob
force-pushed
the
users/bjacob/cdna1-cdna2-data-tiling
branch
from
a89bc41
to
e5899d6
Compare
hanhanW
reviewed
Nov 12, 2024
| @@ -1741,6 +1741,36 @@ iree_generated_e2e_runner_test( | |||
| "requires-gpu-cdna3" | |||
| ) | |||
|
|
|||
| iree_generated_e2e_runner_test( | |||
| NAME | |||
| e2e_matmul_cdna3_dt_f64 | |||
There was a problem hiding this comment.
I'm confused that a cdna3 test suite is added but the PR title is about CDNA1/2. Why?
There was a problem hiding this comment.
Sorry, that's just a mishap while slicing my diff into PRs. This was meant to be part of #19099.
There was a problem hiding this comment.
I see, can you rebase the PR (or merge the main branch into your branch)?
There was a problem hiding this comment.
@hanhanW , if I do that, I will lose the green CI status. The bottom commit here is already in main. Can you review based on looking at the top commit?
There was a problem hiding this comment.
ah, I see. I did not notice that there are two commits. Reviewed and it looks good to me, thanks!
hanhanW
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDNA1/2 machines are going to be in use for a while, and adding data tiling support for an architecture is just a matter of populating those 3 optional fields in
TargetWgpDetails, and the correspondinggpu_materialize_encoding_gfx***.mlirtest adds some coverage around the intrinsics that is useful beyond data tiling.