Check changed files with pytype on github actions #3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoenix-meadowlark
added
infrastructure
…uld be have to be inconsistent to complain about
phoenix-meadowlark
changed the title
GMNGeoffrey
approved these changes
Oct 22, 2020
| @@ -87,10 +87,10 @@ def save_input_values(inputs: Sequence[np.ndarray], | |||
|
|
|||
|
|
|||
| def _setup_mlir_crash_reproducer( | |||
| function: Callable[[Any], Any], | |||
| function: Any, # pytype doesn't support arbitrary Callable[*args, **kwargs] | |||
There was a problem hiding this comment.
I found a thread about this somewhere. I think it said there is a way to write this. Maybe worth investigating, but can be a followup
There was a problem hiding this comment.
SGTM. Could you send a link?
There was a problem hiding this comment.
python/mypy#5876. I would have to understand pytype better to understand all that's going on in that thread. python/typing#264 (comment) and https://stackoverflow.com/q/57837609 may also help
There was a problem hiding this comment.
Yeah, I was looking through those. The first one would be ideal if it were implemented. But the other two make assumptions about types that the function can ingest, which would be inappropriate in our case.
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.