-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added address sanitization feature for translating ML models to LLVM modules #4676
Conversation
I think dylib_executable.cc was moved to https://github.com/google/iree/blob/main/iree/hal/local/loaders/legacy_library_loader.cc @benvanik is it a right file to modify? |
yep! it'll be replaced with system_library_loader soonish (#3580) but anything you do in there I'll port over so ignore it for now. |
As the offline discussion, please try to use the enum type from schema, and rebase to the upstream/main. Thanks! |
Great progress! |
@inho9606 To request a fresh review from a reviewer, in the sidebar of the Conversation tab, click the second icon from right. It will show "Re-request review" if you move the curser on the icon. |
…ment for llvm-sanitize, changed code styls ETC
…e of option strucuture, and fixed style bug"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hi - is there anything I can help with to get this landed? (it would be super useful in debugging workflows) |
I'm just waiting for merge. Please let me know if I need something to update more fore merge. |
It's still showing as a couple of nit comments unresolved. Did you have any updates to push or is this final? |
|
This needs an approval from @benvanik because he requested changes before. |
I hope this works..