Added address sanitization feature for translating ML models to LLVM modules #4676

inho9606 · 2021-02-01T09:48:08Z

Added an option, -iree-llvm-address-sanitizer. Users can turn it on and it injects ASAN to binary of the module.
If ASAN is used on compilation, it changes a bit to true in flat buffer to mark it is compiled with ASAN enabled. IREE runtime can read the bit before running the module. And, it will make an error message if runtime does not have ASAN feature when running address sanitized module.
To test prototype of address sanitizer, I wrote a simple testcase trying to access out of index using torch_index_select. When I executed the module, it displayed address sanitizer error message.
To test micro changes #2, I built two IREE, one is with -DIREE_ENABLE_ASAN_ON option, and another one is without that option. And I checked the one without ASAN option showed IREE_STATUS_UNAVAILABLE error when running a module compiled with ASAN Another one with ASAN option gracefully ran the module.
I hope this works..

hanhanW · 2021-02-01T14:18:43Z

I think dylib_executable.cc was moved to https://github.com/google/iree/blob/main/iree/hal/local/loaders/legacy_library_loader.cc

@benvanik is it a right file to modify?

benvanik · 2021-02-01T23:02:38Z

I think dylib_executable.cc was moved to https://github.com/google/iree/blob/main/iree/hal/local/loaders/legacy_library_loader.cc

@benvanik is it a right file to modify?

yep! it'll be replaced with system_library_loader soonish (#3580) but anything you do in there I'll port over so ignore it for now.

iree/compiler/Dialect/HAL/Target/LLVM/LLVMTargetOptions.cpp

iree/compiler/Dialect/HAL/Target/LLVM/LLVMIRPasses.cpp

iree/compiler/Dialect/HAL/Target/LLVM/LLVMAOTTarget.cpp

build_tools/cmake/iree_copts.cmake

iree/schemas/dylib_executable_def.fbs

iree/compiler/Dialect/HAL/Target/LLVM/LLVMTargetOptions.h

iree/compiler/Dialect/HAL/Target/LLVM/LLVMIRPasses.cpp

hanhanW · 2021-02-03T09:25:57Z

As the offline discussion, please try to use the enum type from schema, and rebase to the upstream/main. Thanks!

…or not

iree/compiler/Dialect/HAL/Target/LLVM/LLVMTargetOptions.h

iree/hal/local/loaders/legacy_library_loader.cc

iree/schemas/dylib_executable_def.fbs

benvanik · 2021-02-05T05:05:55Z

Great progress!

benvanik · 2021-02-05T05:07:09Z

and sorry for the delay - when you push new changes you can click the refresh button here to re-request reviews:

(otherwise the PR still looks like you haven't addressed feedback so people are unlikely to look again)

iree/compiler/Dialect/HAL/Target/LLVM/LLVMTargetOptions.cpp

hanhanW · 2021-02-05T07:23:14Z

and sorry for the delay - when you push new changes you can click the refresh button here to re-request reviews:

(otherwise the PR still looks like you haven't addressed feedback so people are unlikely to look again)

@inho9606 To request a fresh review from a reviewer, in the sidebar of the Conversation tab, click the second icon from right. It will show "Re-request review" if you move the curser on the icon.

…ment for llvm-sanitize, changed code styls ETC

iree/compiler/Dialect/HAL/Target/LLVM/LLVMTargetOptions.h

iree/hal/local/loaders/legacy_library_loader.cc

iree/schemas/dylib_executable_def.fbs

iree/compiler/Dialect/HAL/Target/LLVM/LLVMTargetOptions.cpp

…e of option strucuture, and fixed style bug"

iree/compiler/Dialect/HAL/Target/LLVM/LLVMAOTTarget.cpp

iree/compiler/Dialect/HAL/Target/LLVM/LLVMIRPasses.cpp

iree/compiler/Dialect/HAL/Target/LLVM/LLVMTargetOptions.h

iree/hal/local/loaders/legacy_library_loader.cc

hanhanW

Thanks!

iree/hal/local/loaders/legacy_library_loader.cc

stellaraccident · 2021-02-11T01:21:52Z

Hi - is there anything I can help with to get this landed? (it would be super useful in debugging workflows)

inho9606 · 2021-02-11T01:27:42Z

Hi - is there anything I can help with to get this landed? (it would be super useful in debugging workflows)

I'm just waiting for merge. Please let me know if I need something to update more fore merge.
Thanks

stellaraccident · 2021-02-11T01:29:00Z

I'm just waiting for merge. Please let me know if I need something to update more fore merge.
Thanks

It's still showing as a couple of nit comments unresolved. Did you have any updates to push or is this final?

inho9606 · 2021-02-11T01:32:12Z

I'm just waiting for merge. Please let me know if I need something to update more fore merge.
Thanks

It's still showing as a couple of nit comments unresolved. Did you have any updates to push or is this final?
I think this is final, and at least Hanhan approved it.

hanhanW · 2021-02-11T05:56:00Z

This needs an approval from @benvanik because he requested changes before.

google-cla bot added the cla: yes label Feb 1, 2021

hanhanW self-requested a review February 1, 2021 14:18

ScottTodd added the kokoro:run label Feb 1, 2021

iree-kokoro-bot removed the kokoro:run label Feb 1, 2021

benvanik requested changes Feb 1, 2021

View reviewed changes

hanhanW requested changes Feb 2, 2021

View reviewed changes

hanhanW requested a review from asaadaldien February 2, 2021 20:06

inho9606 added 7 commits February 4, 2021 05:54

Added a address sanitizer option, but need to check if it is turn on …

c9b5324

…or not

Added assertion error for unimplemented address sanitization option

9969eea

Try to fix failed checks

fdf59c9

Added a pass for address sanitization, but not tested yet

8884def

Implemented address-sanitization option feature

6867e61

Fixed formatting,,

4ed1891

update to upstream

a2ed960

inho9606 force-pushed the flatBuffer branch from ba4b9ef to a2ed960 Compare February 4, 2021 07:22

inho9606 added 3 commits February 4, 2021 11:26

Connected enum from schemas to LLVM Target Option"

14e8a6b

refixed iree_copts.cmake file

703ee68

Try to fix clang-format

f5b773d

benvanik requested changes Feb 5, 2021

View reviewed changes

stellaraccident reviewed Feb 5, 2021

View reviewed changes

iree/compiler/Dialect/HAL/Target/LLVM/LLVMTargetOptions.cpp Show resolved Hide resolved

stellaraccident mentioned this pull request Feb 5, 2021

Compiling mobilenetv3 generates out of bounds access on one of the convolutions (in backward pass). #4706

Closed

inho9606 added 2 commits February 5, 2021 09:22

Added enum in LLVM TargetOptions, added error message on invalid argu…

b5cfe2b

…ment for llvm-sanitize, changed code styls ETC

Reverted BUILD and CMakeLists.txt

d638722

inho9606 requested a review from stellaraccident February 5, 2021 09:34

inho9606 requested review from hanhanW and benvanik February 5, 2021 09:34

hanhanW requested changes Feb 5, 2021

View reviewed changes

inho9606 added 4 commits February 8, 2021 03:07

Changed llvm-sanitize input style, moved SanitizerKind enum to outsid…

55822a4

…e of option strucuture, and fixed style bug"

Fixed enum class..

6c66cdd

fixed clang-format....

38d47d6

efixed enum class type... final

2d2cd5f

inho9606 requested a review from hanhanW February 8, 2021 03:45

hanhanW requested changes Feb 8, 2021

View reviewed changes

moved variables in lambda and fixed some issues..

c2a7855

inho9606 requested a review from hanhanW February 8, 2021 11:15

hanhanW approved these changes Feb 8, 2021

View reviewed changes

iree/hal/local/loaders/legacy_library_loader.cc Outdated Show resolved Hide resolved

asaadaldien reviewed Feb 8, 2021

View reviewed changes

iree/hal/local/loaders/legacy_library_loader.cc Show resolved Hide resolved

asaadaldien approved these changes Feb 8, 2021

View reviewed changes

Fixed formatting..

be37c3b

inho9606 requested a review from hanhanW February 9, 2021 01:23

hanhanW approved these changes Feb 9, 2021

View reviewed changes

benvanik approved these changes Feb 11, 2021

View reviewed changes

hanhanW merged commit e775b54 into iree-org:main Feb 11, 2021

inho9606 deleted the flatBuffer branch February 11, 2021 07:36

benvanik added a commit that referenced this pull request Feb 11, 2021

Fixing build breakage from #4676.

685f5bc

benvanik added a commit that referenced this pull request Feb 11, 2021

Fixing build breakage from #4676.

295424b

benvanik added a commit that referenced this pull request Feb 11, 2021

Fixing build breakage from #4676. (#4822)

adcdc6e

This was referenced Feb 11, 2021

Merge main -> google #4825

Closed

Merge main -> google #4834

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added address sanitization feature for translating ML models to LLVM modules #4676

Added address sanitization feature for translating ML models to LLVM modules #4676

inho9606 commented Feb 1, 2021

hanhanW commented Feb 1, 2021

benvanik commented Feb 1, 2021

hanhanW commented Feb 3, 2021

benvanik commented Feb 5, 2021

benvanik commented Feb 5, 2021

hanhanW commented Feb 5, 2021

hanhanW left a comment

stellaraccident commented Feb 11, 2021

inho9606 commented Feb 11, 2021

stellaraccident commented Feb 11, 2021

inho9606 commented Feb 11, 2021 •

edited

Loading

hanhanW commented Feb 11, 2021

Added address sanitization feature for translating ML models to LLVM modules #4676

Added address sanitization feature for translating ML models to LLVM modules #4676

Conversation

inho9606 commented Feb 1, 2021

hanhanW commented Feb 1, 2021

benvanik commented Feb 1, 2021

hanhanW commented Feb 3, 2021

benvanik commented Feb 5, 2021

benvanik commented Feb 5, 2021

hanhanW commented Feb 5, 2021

hanhanW left a comment

Choose a reason for hiding this comment

stellaraccident commented Feb 11, 2021

inho9606 commented Feb 11, 2021

stellaraccident commented Feb 11, 2021

inho9606 commented Feb 11, 2021 • edited Loading

hanhanW commented Feb 11, 2021

inho9606 commented Feb 11, 2021 •

edited

Loading