Wiring up new executable library ABI to LLVM codegen. #4791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvanik
added
compiler/dialects
benvanik
force-pushed
the
benvanik-llvm-abi-new
branch
4 times, most recently
from
3286bba
to
e11f8d1
Compare
asaadaldien
approved these changes
Feb 11, 2021
| // a useful failure though the HAL does not mandate that all overflows are | ||
| // caught and only that they are not harmful - clamping byte ranges and never | ||
| // returning a failure is sufficient. | ||
| typedef int (*iree_hal_executable_dispatch_v0_t)( |
There was a problem hiding this comment.
+1, I think will be very useful (in the future) having executable to return some kind of status e.g block of code that verifies the dynamic shapes at runtime.
| const size_t* binding_lengths; | ||
|
|
||
| // Optional imported functions available for use within the executable. | ||
| const iree_hal_executable_import_table_v0_t* imports; |
There was a problem hiding this comment.
Still needs to be defined/requires goo - but at least there's a placeholder I can point to when people ask where it would go :)
Using this for all executables will reduce the overhead in the common case (statically/dynamically linked codegen) where we care about perf and require minimal translation for the weirder cases (VMLA) where we don't.
This switches the generated code to using the new executable library signature while still routing all the outputs through the flatbuffers. Progress on #3580.
benvanik
force-pushed
the
benvanik-llvm-abi-new
branch
from
e11f8d1
to
123649a
Compare
This was referenced Feb 11, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the runtime and generated code to using the new executable
library signature while still routing all the outputs through the flatbuffers.
Future changes will start generating the library metadata structures.
Progress on #3580.