-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove special casing for IreeFileCheck in iree_lit_test.cmake #5209
Conversation
set(_DATA_DEP_PATHS) | ||
foreach(_DATA_DEP ${_RULE_DATA}) | ||
string(REPLACE "::" "_" _DATA_DEP_NAME ${_DATA_DEP}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still can't use https://github.com/google/iree/blob/b67af5abfb8d3676ba20bba4dbb012d3763742cd/build_tools/cmake/iree_macros.cmake#L191-L197
here, right? IIRC, there's something about https://github.com/google/iree/blob/b67af5abfb8d3676ba20bba4dbb012d3763742cd/build_tools/cmake/iree_installed_test.cmake#L40-L45
that isn't a target we can add dependencies for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests aren't targets in CMake :-/
Cannot add target-level dependencies to non-existent target
"iree/samples/custom_modules/dialect/test/custom_ops.mlir.test".
* 82d8765 Merge branch 'google' into main-to-google * b7e2b09 Remove special casing for IreeFileCheck in iree_lit_test.cmake (#5209) * b67af5a Clean up several CMake options configured for our CI builds. (#5197) * ea8b82d Integrate MLIR-EmitC at iml130/mlir-emitc@68547d0 (#5205) * 10d9ea1 Make CPU/GPU end-to-end testing in Linalg on tensors/buffers align. (#5203) * ff69d02 Move prepration of benchmark files to python script. (#5201) * 0c2f9e8 Bump Abseil-cpp submodule to LTS 20200923, Patch 3 (#5198) * 6ac0023 Add runtime tracing support to passes under IREE's PassManager usage. (#5160) * 2e41217 Bump Benchmark submodule to 39c8d58 (#5196) * 663ab93 Adjust UnixLinkerTool flags used for Apple targets. (#5164) * 963beb9 Plumb pooling ops through Linalg on tensors path. (#5136) * a33f72f Plumb depthwise convolution in Linalg on tensors. (#5189) * 2864ee4 Add restrictions for enabling generic op vectorization. (#5188) * 4f218a8 Make sure convolution vectorization is off when the option flag is off (#5187) * 44736b5 build_tools:cmake:riscv: Fix the system library path (#5175) * 96e9c49 Switching from mhlo::ConvertOp to ZeroExtendI for i1->i8 conversion. (#5119) * da4ad51 Fix and re-enable jax testing (#5183) * 301bc15 Merge google -> main (#5182) * 400719c Shuffling around/removing some HLO deps. * 9ba1d57 Enable MobileBert on GPU for the linalg on tensors path. (#5180) * 52f02af Resolve name conflicts while linking executables in LLVM. (#5179) * 4a732d3 Removing the post-partitioning conversion pass as it is unused. We've built up.. COPYBARA_INTEGRATE_REVIEW=#5212 from ScottTodd:main-to-google 82d8765 PiperOrigin-RevId: 364658113
* 82d8765 Merge branch 'google' into main-to-google * b7e2b09 Remove special casing for IreeFileCheck in iree_lit_test.cmake (#5209) * b67af5a Clean up several CMake options configured for our CI builds. (#5197) * ea8b82d Integrate MLIR-EmitC at iml130/mlir-emitc@68547d0 (#5205) * 10d9ea1 Make CPU/GPU end-to-end testing in Linalg on tensors/buffers align. (#5203) * ff69d02 Move prepration of benchmark files to python script. (#5201) * 0c2f9e8 Bump Abseil-cpp submodule to LTS 20200923, Patch 3 (#5198) * 6ac0023 Add runtime tracing support to passes under IREE's PassManager usage. (#5160) * 2e41217 Bump Benchmark submodule to 39c8d58 (#5196) * 663ab93 Adjust UnixLinkerTool flags used for Apple targets. (#5164) * 963beb9 Plumb pooling ops through Linalg on tensors path. (#5136) * a33f72f Plumb depthwise convolution in Linalg on tensors. (#5189) * 2864ee4 Add restrictions for enabling generic op vectorization. (#5188) * 4f218a8 Make sure convolution vectorization is off when the option flag is off (#5187) * 44736b5 build_tools:cmake:riscv: Fix the system library path (#5175) * 96e9c49 Switching from mhlo::ConvertOp to ZeroExtendI for i1->i8 conversion. (#5119) * da4ad51 Fix and re-enable jax testing (#5183) * 301bc15 Merge google -> main (#5182) * 400719c Shuffling around/removing some HLO deps. * 9ba1d57 Enable MobileBert on GPU for the linalg on tensors path. (#5180) * 52f02af Resolve name conflicts while linking executables in LLVM. (#5179) * 4a732d3 Removing the post-partitioning conversion pass as it is unused. We've built up.. PiperOrigin-RevId: 364658113
No description provided.