Moving the HAL module shims into iree/vm/.
#5532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These still need to be generated someday but for now this at least allows us to share them with emitc, the HAL, and VMVX.
|
Moving this is fine for me, but the pipeline tells the current state is broken. Will be glad to test if it works with EmitC enabled after the current issues (with the default build) are resolved. |
Cleaning up iree/base/api.h is high on the list - it should be using iree/base/attributes.h instead of defining its own.
|
PTAL |
marbre
approved these changes
Apr 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will be reused by the VMVX module. For now I moved the existing shims that emitc is using to prevent that from breaking until we can combine them.