Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing binding lengths size mismatch. #5558

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Fixing binding lengths size mismatch. #5558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iree/hal/local/elf/elf_module_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ TEST_F(ELFModuleTest, Check) {
float arg0[4] = {1.0f, 2.0f, 3.0f, 4.0f};
float arg1[4] = {100.0f, 200.0f, 300.0f, 400.0f};
float ret0[4] = {0.0f, 0.0f, 0.0f, 0.0f};
iree_device_size_t binding_lengths[3] = {
size_t binding_lengths[3] = {
sizeof(arg0),
sizeof(arg1),
sizeof(ret0),
Expand Down
10 changes: 4 additions & 6 deletions iree/hal/local/inline_command_buffer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,15 @@ typedef struct {
// iree_hal_buffer_mapping_t and map/unmap where appropriate.
void* full_bindings[IREE_HAL_LOCAL_MAX_DESCRIPTOR_SET_COUNT *
IREE_HAL_LOCAL_MAX_DESCRIPTOR_BINDING_COUNT];
iree_device_size_t
full_binding_lengths[IREE_HAL_LOCAL_MAX_DESCRIPTOR_SET_COUNT *
IREE_HAL_LOCAL_MAX_DESCRIPTOR_BINDING_COUNT];
size_t full_binding_lengths[IREE_HAL_LOCAL_MAX_DESCRIPTOR_SET_COUNT *
IREE_HAL_LOCAL_MAX_DESCRIPTOR_BINDING_COUNT];

// Packed bindings scratch space used during dispatch. Executable bindings
// are packed into a dense list with unused bindings removed.
void* packed_bindings[IREE_HAL_LOCAL_MAX_DESCRIPTOR_SET_COUNT *
IREE_HAL_LOCAL_MAX_DESCRIPTOR_BINDING_COUNT];
iree_device_size_t
packed_binding_lengths[IREE_HAL_LOCAL_MAX_DESCRIPTOR_SET_COUNT *
IREE_HAL_LOCAL_MAX_DESCRIPTOR_BINDING_COUNT];
size_t packed_binding_lengths[IREE_HAL_LOCAL_MAX_DESCRIPTOR_SET_COUNT *
IREE_HAL_LOCAL_MAX_DESCRIPTOR_BINDING_COUNT];

// All available push constants updated each time push_constants is called.
// Reset only with the command buffer and otherwise will maintain its values
Expand Down