R4R: Censorship Slash #1080
Merged
R4R: Censorship Slash #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haifengxi
requested review from
wukongcheng,
chengwenxi,
abelliumnt,
haifengxi and
kidinamoto01
and removed request for
wukongcheng and
chengwenxi
MrXJC
force-pushed
the
censorship2
branch
3 times, most recently
from
61b1e96
to
32fefec
Compare
wukongcheng
reviewed
Jan 16, 2019
modules/slashing/keeper.go
Outdated
| @@ -174,6 +174,50 @@ func (k Keeper) handleValidatorSignature(ctx sdk.Context, addr crypto.Address, p | |||
| return | |||
| } | |||
|
|
|||
| // Punish proposer censorship by slashing malefactor's stake | |||
| func (k Keeper) handleProposalCensorship(ctx sdk.Context, addr crypto.Address, infractionHeight int64) (tags sdk.Tags) { | |||
There was a problem hiding this comment.
handleProposalCensorship => handleProposerCensorship
wukongcheng
reviewed
Jan 16, 2019
modules/slashing/tick.go
Outdated
| @@ -40,3 +40,20 @@ func BeginBlocker(ctx sdk.Context, req abci.RequestBeginBlock, sk Keeper) (tags | |||
|
|
|||
| return | |||
| } | |||
|
|
|||
| // slashing begin block functionality | |||
There was a problem hiding this comment.
slashing end block functionality
|
If a Validator is slash twice at the same block height(double-sign & invalid tx), each time slash 20%, then the total slash is 36% instead of 40%. |
wukongcheng
reviewed
Jan 16, 2019
modules/slashing/keeper.go
Outdated
| // ABCI, and now received as evidence. | ||
| // The revisedFraction (which is the new fraction to be slashed) is passed | ||
| // in separately to separately slash unbonding and rebonding delegations. | ||
| tags = k.validatorSet.Slash(ctx, consAddr,infractionHeight, validator.GetPower().RoundInt64(), sdk.NewDecWithPrec(5,2)) |
There was a problem hiding this comment.
The hardcode sdk.NewDecWithPrec(5,2) should be defined as a gov param.
There was a problem hiding this comment.
Any new param or param change needs to be added to the params spec. @MrXJC @wukongcheng
There was a problem hiding this comment.
OK we also need a ProposerCensorshipUnbondDuration like DoubleSignUnbondDuration
wukongcheng
previously approved these changes
Jan 17, 2019
chengwenxi
previously approved these changes
Jan 17, 2019
abelliumnt
approved these changes
Jan 17, 2019
wukongcheng
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target Issue: #1052