upgrade module : design doc and the framework codes #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelliumnt
reviewed
Jul 25, 2018
| * switch的投票将在约定高度进行检查，需要95%的Voting Power才视为投票通过 | ||
| * switch通过后开启切换流程： | ||
| 1. check_tx全部返回fail，以拒绝新tx的处理 | ||
| 2. 处理mempool中留存的tx，直到生成一个empty block |
There was a problem hiding this comment.
一个empty block可能有点少，只有一个空块只能说明这个块对应的proposal 节点的memory pool里面是空的，建议等多个empty block
There was a problem hiding this comment.
社区会公告在第多少高度进行版本升级，提醒届时会终止服务，不要在升级时间段内发交易。所以这里算是一个防御检查，保守一点可以先等两个空块，后续压测发现不足的话再调整。
abelliumnt
reviewed
Jul 25, 2018
| 2. 处理mempool中留存的tx，直到生成一个empty block | ||
| 3. 配置新版本的路由开关，并打开check_tx接受新tx | ||
| * 发生老版本AppHash冲突，检查自己是否在switch voter list中，否则reset rootMultiStore到上一个commit，并下载新版本开始同步block | ||
| * 新增Module的升级方式（现有Module逻辑修改也通过新Module完成），新老版本的Module共享同一个store，对于查询需要路由到相应版本的Module |
There was a problem hiding this comment.
从iris角度看，查询操作就是直接访问store，然后返回value和proof，具体字段的解析逻辑都是iriscli里面，所以iris本身不需要对查询操作做特殊处理，可能需要在iriscli里面做改动
abelliumnt
reviewed
Jul 25, 2018
| @@ -0,0 +1,32 @@ | |||
| package upgrade | |||
There was a problem hiding this comment.
这个switch msg应该是中交易吧，那发起这个交易的应该是轻客户端做的吧，是不是要求一定要 validator owner的签名
wukongcheng
commented
Jul 25, 2018
| 1. check_tx全部返回fail，以拒绝新tx的处理 | ||
| 2. 处理mempool中留存的tx，直到生成一个empty block | ||
| 3. 配置新版本的路由开关，并打开check_tx接受新tx | ||
| * 发生老版本AppHash冲突，检查自己是否在switch voter list中，否则reset rootMultiStore到上一个commit，并下载新版本开始同步block |
There was a problem hiding this comment.
回滚是应该的，但是之前只考虑了App中store当前版本的回滚，目前讨论下来还需要用新版本软件对自己tendermint node中的last block进行replay，否则还是会有AppHash冲突
wukongcheng
added a commit
that referenced
this pull request
Aug 27, 2018
upgrade module : design doc and the framework codes
Nimrostafarian
pushed a commit
to petri-labs/petrihub
that referenced
this pull request
Jan 3, 2023
…-tokens feat: take rate does not result in zero tokens
This was referenced Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.