Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github build #3

Merged
merged 5 commits into from
Mar 25, 2024
Merged

github build #3

merged 5 commits into from
Mar 25, 2024

Conversation

jowparks
Copy link
Contributor

@jowparks jowparks commented Mar 25, 2024 •
edited
Loading

Adds GHA for build which verifies

  • rust lib can built
  • cargo scripts can run
  • mobile-app prebuild can run (along with pod install)

jowparks
jowparks commented Mar 25, 2024
View reviewed changes
packages/ironfish-native-module/.gitignore
@@ -38,6 +39,7 @@ local.properties
android.iml
android/app/libs
android/keystores/debug.keystore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing we don't want the compiled binaries checked in?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@jowparks jowparks marked this pull request as ready for review March 25, 2024 21:34
@jowparks jowparks requested a review from dgca March 25, 2024 21:34
@jowparks jowparks merged commit 62d96c4 into main Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgca dgca dgca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jowparks @dgca