Add basic AppV2 compatability #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add same `app.object` compatability to item sheet portion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently sound controls are added based on calls to
renderActorSheetandrenderItemSheet, for systems like the one I'm developing that are moving over to AppV2, these hooks aren't called as they have been replaced withrenderActorSheetV2andrenderItemSheetV2.Updated the hooks here so they call both app v1 and v2 hooks.
Besides this,
app.objectis no longer in use, for my system's compatability sake, I've added getters to my actor/item sheets to resolve this, but I've included a patch that should work for the majority of systems otherwise.