Upgrade to Bootstrap 5 #1020
Merged
Upgrade to Bootstrap 5 #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This icon was added recently, but does not now replace the Bootstrap default icon which is used in all other select elements across the Ada site. There is little difference between them, especially at ~10px across!
The whole point of classNames is to allow you to dynamically generate the correct class string without needing to do string manipulation.
Also fix poor TSX formatting in the file too. Previously Bootstrap added spacing to buttons next to one another if both were using the now-removed "btn-block" class.
@popperjs is now an explicit import rather than being bundled in bootstrap. Similarly, katex was upgraded on this branch. Both of these use ESM rather CJS and so where causing import errors as they were not converted. They are no ignored in the ignore list (that is they are actively converted) into the required format.
Versions after this cause MSW request handling to fail. Hopefully a MSW upgrade will fix this, but that's a job for later.
Addresses "tearing" issue in screenshots, see cypress-io/cypress#2681
Resolves test failure caused by attempting to parse an image in Leaflet.
It is not supposed to be bold, but small now no longer removes the larger font-weight.
We may get rid of this layout, but currently aiming for consistency with the previous layout.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -8,6 +8,7 @@ | |||
| import {NEWS_PODS_PER_PAGE} from "../../services"; | |||
| import { IsaacPodDTO } from "../../../IsaacApiTypes"; | |||
| import { PageFragment } from "../elements/PageFragment"; | |||
| import classNames from "classnames"; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
# Conflicts: # src/test/pages/__image_snapshots__/phy/Set Assignments should have no visual regressions #0.png
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades from Bootstrap 4.6 to 5.3. We would ideally like version 5.3.4 to fit this problem with console warnings in dev; this patch should not change anything visually.