Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Gist comments and mentions don't trigger notifications #21

Closed
max-mapper opened this issue Jun 4, 2013 · 371 comments
Closed

Gist comments and mentions don't trigger notifications #21

max-mapper opened this issue Jun 4, 2013 · 371 comments

Comments

@max-mapper
Copy link

this used to work.

to reproduce:

  • make a gist
  • have someone leave a command or @ mention you
  • you won't receive any emails
@luk-

This comment has been minimized.

@kastiglione
Copy link

I asked support about this, and on May 31st they said:

Notifications for gist comments isn't implemented now, but it's something the team has discussed, so this could change in the future. We'll definitely announce this on our blog if it gets pushed out.

@balupton
Copy link

👍 it is soooooooo infuriating, it is a common occurrence where I discover a very important comment or even a job offer that is a year old or so on a gist

@balupton
Copy link

If anyone has any 3rd party solutions to this, then do please post!

@commonsguy
Copy link

And, according to this gist, this is a fairly popular feature request/bug fix. What is the point of having comments if the developer of the gist will not hear them (short of manually monitoring the page)? After all, we cannot use existing tools for change detection, partially because the page always changes ("Created NNN days ago") and partially because robots.txt blocks monitoring of gists.

@swrobel

This comment has been minimized.

1 similar comment
@r-a-y
Copy link

r-a-y commented Oct 20, 2013

👍

@eddieajau
Copy link

👍 - very annoying

@BrainCrumbz

This comment has been minimized.

1 similar comment
@pstadler
Copy link

+1

@X4
Copy link

X4 commented Nov 5, 2013

👍
I really need it too, but don't immediately send the notification and don't include the message in the notification!
Every edit should increase the notification by 15minutes.

@patcon
Copy link

patcon commented Nov 5, 2013

@X4 that sounds like i might be a separate issue request that's great in its own right..? re: delaying notifications using some known criteria.

Would it be cool to open another issue on that?

@X4
Copy link

X4 commented Nov 6, 2013

@patcon hmm, I believe that it's not required, because the changes would be both very simple and results in extending the function responsible for writing a notification flag that makes the notification icon on the top left shine. I assume GitHub uses some kind of asynchronous message passing system, so delaying a notification due to an edit under 15min would just require an update of the timestamp in the message queue.
For efficiency reasons, I would not set it to a fixed time of 15minutes, but let it be larger, when required, so that more queued items can be updated at once. This would result in less updates.

@patcon
Copy link

patcon commented Nov 6, 2013

Sorry, wasn't saying it wasn't simple, but just that it's not what the OP was asking about, and that it would definitely be useful for other things (as opposed to just gist comments) :)

@mehulkar

This comment has been minimized.

1 similar comment
@Mithgol
Copy link

Mithgol commented Dec 13, 2013

👍

@mburgert

This comment has been minimized.

@kramerc
Copy link

kramerc commented Dec 25, 2013

For the interim, I made a script that send me emails about new comments left on my gists and I made it available at https://github.com/kramerc/gist_notifier.

@headius

This comment has been minimized.

@narqo
Copy link

narqo commented Jan 7, 2014

👍 — it would be great!

@skuehn

This comment has been minimized.

1 similar comment
@eshilts
Copy link

eshilts commented Jan 10, 2014

👍

@gep13

This comment has been minimized.

2 similar comments
@cdeszaq
Copy link

cdeszaq commented Jan 27, 2014

👍

@timyates
Copy link

👍

@balupton
Copy link

balupton commented Feb 5, 2014

@jookyboi could you perhaps please bring a comments listing and comments notifications into gistbox?

@nanobeep
Copy link

Oh man. Just discovered an important comment from 5 months ago on one of my gists. Hope they don't think I'm an asshole for not replying. Was never notified :/

Please help us not look like assholes :)

@nicholashagen

This comment has been minimized.

1 similar comment
@zoerooney
Copy link

+1

@jcsrb
Copy link

jcsrb commented Mar 13, 2019

CEO has been made aware https://twitter.com/natfriedman/status/1105868787419496448

@matt-curtis
Copy link

CEO has been made aware https://twitter.com/natfriedman/status/1105868787419496448

This is truly a blessed day.

@l3ender
Copy link

l3ender commented Mar 13, 2019 via email

@mspiegel
Copy link

The GitHub App "Always Be Closing" (ABC) now has gist comment notifications. You can use it in the interim until GitHub implements the feature :) https://www.thoughtdealership.com/post/gist-notifications/

@vipulgupta2048
Copy link

Hey you all,
I think the community and we all would really benefit from having this feature in our GitHub gists. I just tweeted for having the same, would love to get some support - https://twitter.com/vipulgupta2048/status/1119563773193273344

Let's close this 6-year-old running issue for good ❤️

@vipulgupta2048
Copy link

He actually replied !!! - Check it out the tweet

@Scrxtchy
Copy link

Pretty much confirms what we already know what would happen it's just a matter of when

@becca
Copy link

becca commented May 8, 2019

👋notifications for new gists (and new comments on gists) are now available! https://github.blog/changelog/2019-05-08-gist-notifications/

hoping this helps you all out 😊

@Scrxtchy
Copy link

Scrxtchy commented May 8, 2019

Thank you becca 🎉

@BenMorel
Copy link

BenMorel commented May 8, 2019

Big day! 🎉

I'm surprised that I have to manually click Subscribe on each of my gists though, shouldn't I be subscribed automatically?

@becca
Copy link

becca commented May 8, 2019

@BenMorel we have not yet transitioned authors to being automatically subscribed to their own gists. this is up next 👍

@oliveratgithub
Copy link

@becca @BenMorel but then the help page is misleading? Or is the transition being done in the next few days / hours?

You'll receive a notification when:

You are the author of the gist.
Someone mentions you in a gist.
You comment in another persons's gist.
You subscribe to a gist, by clicking Subscribe at the top any gist.

@BenMorel
Copy link

BenMorel commented May 8, 2019

Thank you Becca, will this be retroactive, i.e. will I get subscribed to all of my existing gists soon, or only to my new gists?

@Scrxtchy
Copy link

Scrxtchy commented May 8, 2019

It sounds like it will take some time, there are probably tens of millions of gists to process through

@Logerfo
Copy link

Logerfo commented May 8, 2019

From now on, you already get automatically subscribed to new gists you create, go ahead and try. The team will make the retroactive transition soon enough.

@BenMorel
Copy link

BenMorel commented May 8, 2019

Indeed, I'm automatically subscribed to new gists. I'll wait a bit before looping through my gists and clicking Subscribe on each of them, then 👍

(or before I finish writing this comment, someone in this thread will have written a script to do this automatically 😁 )

@becca
Copy link

becca commented May 8, 2019

@oliveratgithub we'll update the product documentation 👍

@BenMorel right now it's only new gists. we're going to work on the backfill to make it easier to be subscribed to gists you have authored from the past. i'll let you know when this lands but as @Scrxtchy mentioned it's a bit of a transition 😅 ...either way, we're on it!

@BigglesZX
Copy link

@becca Amazing work, thank you! 👏

@dandv
Copy link

dandv commented May 8, 2019

One giant step for Gist! But wait, this hasn't happened yet but will happen 4 hours from now!?

image

(my time has been set correctly for months, I haven't moved, not using a VPN etc.)

@usmonster
Copy link

@dandv wrote:

One giant step for Gist! But wait, this hasn't happened yet but will happen 4 hours from now!?

image

(my time has been set correctly for months, I haven't moved, not using a VPN etc.)

#1576

@JMichaelTX
Copy link

@becca and the entire GitHub team: Thank you very much for implementing this long needed feature! 👍

I can confirm that Gist notifications are now working, provided that you first subscribe to your own Gist.
I understand that eventually GitHub will auto-subscribe the owner to all of his/her Gists, but for now you much manually subscribe to those Gists for which you want to receive notifications.

I received email notification within a few (2-5) minutes of when the comment was made.

@JMichaelTX

This comment has been minimized.

@JMichaelTX
Copy link

I can confirm email notifications are now working.

@TPS TPS added implemented and removed WIP labels May 9, 2019
@TPS TPS closed this as completed May 9, 2019
@becca
Copy link

becca commented Jun 3, 2019

👋just a quick update that we have been working on subscribing authors to their own previously authored gists (so you don't have to find and manually subscribe to each). this transition is now done! https://github.blog/changelog/2019-06-03-authors-subscribed-to-gists/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests