Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the abort controller check #217

Closed
wants to merge 1 commit into from
Closed

Fix the abort controller check #217

wants to merge 1 commit into from

Conversation

agalatan
Copy link

  • The typeof AbortController !== undefined check is incorrect, as typeof gives you strings

  • In my case, this broke node-gyp install, which depends (indirectly) on lru-cache

Copy link

@bytemain bytemain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isaacs
Copy link
Owner

isaacs commented Mar 18, 2022

🤦

@isaacs isaacs closed this in 7a7abe5 Mar 18, 2022
@isaacs
Copy link
Owner

isaacs commented Mar 18, 2022

thanks.

ftalburt added a commit to ftalburt/fantasy-hockey-notifier-cdk that referenced this pull request Mar 19, 2022
projen upgrade command is failing because of a bug introduced in version 7.7.0 of lru-cache. See isaacs/node-lru-cache#217 for details.
ftalburt added a commit to ftalburt/fantasy-hockey-notifier-cdk that referenced this pull request Mar 19, 2022
projen upgrade command is failing because of a bug introduced in version 7.7.0 of lru-cache. See isaacs/node-lru-cache#217 for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants