Remove DOM lib reference in TypeScript types #247
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
In backend projects, forcing the TypeScript compiler to import the DOM lib can causes issues, in particular shadowing of the Node.js or Cloudflare global types like
Request
.This is somewhat of a known issue with TypeScript and packages that include the
/// <reference lib="DOM" />
snippet break Node.js and other backend-only projects:superagent
is typically a package that used to cause the same issue on server-side projects and it looks like they chose to remove the DOM lib reference as well