Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues #318

Closed
wants to merge 1 commit into from
Closed

fix issues #318

wants to merge 1 commit into from

Conversation

leagmain
Copy link

  1. quiver dependencies version conficts
  2. generated code use experimental features

1. quiver dependencies version conficts
2. generated code use experimental features
@MarcelGarus
Copy link
Contributor

Is the dartx update the same as in PR #318 or #277?
Also, the collection-for feature was introduced over a year ago and AFAIK it's not experimental anymore.

@leagmain
Copy link
Author

Is the dartx update the same as in PR #318 or #277?
Also, the collection-for feature was introduced over a year ago and AFAIK it's not experimental anymore.

  • yes, dartx update as same as bump dartx dependency version #277 .
  • I am not clear about the spread-collection feature, I used stable flutter version, it warning me with the auto generated code, I think we should use the common base solution in generated code.
    Below is my dart and flutter version:
Flutter 1.17.1 • channel stable • https://github.com/flutter/flutter.git
Framework • revision f7a6a7906b (6 days ago) • 2020-05-12 18:39:00 -0700
Engine • revision 6bc433c6b6
Tools • Dart 2.8.2

@MarcelGarus
Copy link
Contributor

What is the environment in your pubspec.yaml? It should be something like sdk: '>=2.7.0 <3.0.0'.
If it's lower, it's telling Dart "the code in this project should also compile with a Dart SDK of a lower version", which is usually not what you want.

@leagmain
Copy link
Author

Hi @MarcelGarus you are right!
My environment is sdk: ">=2.1.0 <3.0.0", and this was generate automatically by flutter.
It's lower that 2.3.0, which has spread-collection features in dart. It's ok for me, I can accept it now to manually upgrade my environment to higher version.

One more question, when do wo plan to release next hive-generator?

@MarcelGarus
Copy link
Contributor

That's a good question. @leisim is the maintainer of this repo (and AFAIK the only person able to pub lish the package right now).
He's not been responsive for the past few weeks, but will be back soon, whenever that may be. Then, he could publish a new version. Until then, I guess we just have to wait.

@leagmain
Copy link
Author

Thanks @MarcelGarus nice work with your guys.

@leagmain leagmain closed this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants