Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get indexDB selectively based on window property #802

Merged
merged 1 commit into from
Oct 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions hive/lib/src/backend/js/backend_manager.dart
Original file line number Diff line number Diff line change
@@ -1,17 +1,20 @@
import 'dart:html';
import 'dart:indexed_db';

import 'dart:js' as js;
import 'package:hive/hive.dart';
import 'package:hive/src/backend/js/storage_backend_js.dart';
import 'package:hive/src/backend/storage_backend.dart';

/// Opens IndexedDB databases
class BackendManager implements BackendManagerInterface {
IdbFactory? get indexedDB => js.context.hasProperty('window')
? window.indexedDB
: WorkerGlobalScope.instance.indexedDB;

@override
Future<StorageBackend> open(
String name, String? path, bool crashRecovery, HiveCipher? cipher) async {
var db =
await window.indexedDB!.open(name, version: 1, onUpgradeNeeded: (e) {
var db = await indexedDB!.open(name, version: 1, onUpgradeNeeded: (e) {
var db = e.target.result as Database;
if (!db.objectStoreNames!.contains('box')) {
db.createObjectStore('box');
Expand All @@ -23,15 +26,15 @@ class BackendManager implements BackendManagerInterface {

@override
Future<void> deleteBox(String name, String? path) {
return window.indexedDB!.deleteDatabase(name);
return indexedDB!.deleteDatabase(name);
}

@override
Future<bool> boxExists(String name, String? path) async {
// https://stackoverflow.com/a/17473952
try {
var _exists = true;
await window.indexedDB!.open(name, version: 1, onUpgradeNeeded: (e) {
await indexedDB!.open(name, version: 1, onUpgradeNeeded: (e) {
e.target.transaction!.abort();
_exists = false;
});
Expand Down
6 changes: 5 additions & 1 deletion hive/lib/src/backend/js/storage_backend_js.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import 'dart:html';
import 'dart:indexed_db';
import 'dart:js_util';
import 'dart:typed_data';
import 'dart:js' as js;

import 'package:hive/hive.dart';
import 'package:hive/src/backend/storage_backend.dart';
Expand Down Expand Up @@ -199,6 +200,9 @@ class StorageBackendJs extends StorageBackend {

@override
Future<void> deleteFromDisk() {
return window.indexedDB!.deleteDatabase(_db.name!);
final indexDB = js.context.hasProperty('window')
? window.indexedDB
: WorkerGlobalScope.instance.indexedDB;
return indexDB!.deleteDatabase(_db.name!);
}
}