Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide fallback backend manager #968

Merged
merged 1 commit into from
May 18, 2022

Conversation

TheOneWithTheBraid
Copy link
Contributor

  • remove need for manual Hive.init() call
  • provide default backend manager
  • fix most tests

Fixes: #967

Signed-off-by: TheOneWithTheBraid [email protected]

Copy link
Contributor

@themisir themisir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but tests seems to be failing (seems like there's missing adapter)

hive/test/integration/integration.dart Outdated Show resolved Hide resolved
- remove need for manual `Hive.init()` call
- provide default backend manager
- fix most tests

Fixes: #967

Signed-off-by: TheOneWithTheBraid <[email protected]>
@TheOneWithTheBraid TheOneWithTheBraid merged commit bb23e21 into master May 18, 2022
@TheOneWithTheBraid TheOneWithTheBraid deleted the braid/backend-manager-fallback branch May 18, 2022 10:32
@TheOneWithTheBraid
Copy link
Contributor Author

@themisir We should create a release of both Hive and Hive Flutter now.

@themisir
Copy link
Contributor

Not really, we didn't changed hive_flutter, I'll just retract previous hive version so hive_flutter will not resolve it next time

@TheOneWithTheBraid
Copy link
Contributor Author

I opened a corresponding PR. It's not important anymore, as this PR here removed the need for Hive.init on web but still, as a future prospect of web workers, I exposed the backend preference to Hive Flutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Unexpected null value
2 participants