Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(render): nn.Parameter codegen #122

Merged
merged 4 commits into from
Oct 5, 2023
Merged

fix(render): nn.Parameter codegen #122

merged 4 commits into from
Oct 5, 2023

Conversation

ganler
Copy link
Member

@ganler ganler commented Oct 4, 2023 •
edited
Loading

Fix #121. The codegen for nn.Parameter:

  1. removed an extra right bracket
  2. explicitly specified requires_grad= in generated code
  3. used object attr to reference nn.Parameter instead of relying on named_parameters()

@ganler ganler requested a review from Co1lin October 4, 2023 20:41
@ganler ganler mentioned this pull request Oct 4, 2023
Closed
@ganler ganler changed the title fix(render): remove extra bracket for nn.Parameter codegen fix(render): nn.Parameter codegen Oct 4, 2023
@ganler ganler merged commit 8010210 into ise-uiuc:main Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Co1lin Co1lin Co1lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Render seems to not work
2 participants
@ganler @Co1lin