Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: torch JIT #79

Merged
merged 5 commits into from
Feb 19, 2023
Merged

feat: torch JIT #79

merged 5 commits into from
Feb 19, 2023

Conversation

Co1lin
Copy link
Collaborator

@Co1lin Co1lin commented Feb 19, 2023

Complete #78

@Co1lin Co1lin requested a review from ganler February 19, 2023 05:20
ganler
ganler requested changes Feb 19, 2023
View reviewed changes
Copy link
Member

@ganler ganler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great job! LGTM. Just a few minor suggestions. Could you also consider adding an end-to-end model gen script in https://github.com/ise-uiuc/nnsmith/blob/main/.github/workflows/ci.yaml#L32.

nnsmith/backends/torchjit.py Outdated Show resolved Hide resolved
ganler
ganler approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@ganler ganler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ganler ganler merged commit 48a52b1 into main Feb 19, 2023
@ganler ganler deleted the feat_torchjit branch February 19, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganler ganler ganler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Co1lin @ganler