Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OptionalDouble and OptionalLong #13

Merged
merged 6 commits into from
Aug 24, 2023
Merged

Conversation

iselo
Copy link
Owner

@iselo iselo commented Aug 24, 2023

This PR eliminates if-statements and additional presence variable, reduces bytecode size and code execution passthrough.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0fa0e9e) 100.00% compared to head (3ef21c2) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #13   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        45        83   +38     
===========================================
  Files              2         4    +2     
  Lines             93       171   +78     
  Branches           3         6    +3     
===========================================
+ Hits              93       171   +78     
Files Changed Coverage Δ
lib/src/main/java/co/raccoons/meeko/Optional.java 100.00% <ø> (ø)
...b/src/main/java/co/raccoons/meeko/OptionalInt.java 100.00% <ø> (ø)
...rc/main/java/co/raccoons/meeko/OptionalDouble.java 100.00% <100.00%> (ø)
.../src/main/java/co/raccoons/meeko/OptionalLong.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iselo iselo merged commit 7a3518e into master Aug 24, 2023
8 checks passed
@iselo iselo deleted the feature/optional-double branch August 24, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant