Minor/refactoring 🖖 #12
Open
+32
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishkawa
reviewed
Oct 10, 2018
| @@ -9,15 +9,25 @@ | |||
| import UIKit | |||
|
|
|||
| public class CollectionViewDataSource<CellDeclaration>: NSObject, UICollectionViewDataSource { | |||
|
|
|||
| // MARK: Public Properties | |||
There was a problem hiding this comment.
Personally, I think these kinds of comments are redundant.
|
|
||
| // MARK: Init | ||
|
|
||
| public init(binderFromDeclaration: @escaping Configurator) { |
There was a problem hiding this comment.
(CellDeclaration) -> CellBinder is short enough and clearer than Configurator.
| @@ -12,7 +12,7 @@ import DataSourceKit | |||
| class CTableViewCell: UITableViewCell { | |||
| var idLabel = UILabel(frame: .zero) | |||
|
|
|||
| override init(style: UITableViewCellStyle, reuseIdentifier: String?) { | |||
| override init(style: UITableViewCell.CellStyle, reuseIdentifier: String?) { | |||
There was a problem hiding this comment.
This change is applied in #13, so please update this branch. Sorry for my late response 🙇
| @@ -26,7 +26,7 @@ public struct CellBinder { | |||
| self.reuseIdentifier = reuseIdentifier | |||
| self.configureCell = { cell in | |||
| guard let cell = cell as? Cell else { | |||
| fatalError("Could not cast UICollectionView cell to \(Cell.self)") | |||
| fatalError("Could not cast cell to \(Cell.self)") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I refactor some part of the code.