feat(native-app): update nav bar right buttons and title on all tab screens should be big #15478
Conversation
WalkthroughThe recent changes involve refining the button functionality and screen-specific logic across multiple screens in the app. The Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (6)
- apps/native/app/src/screens/applications/applications.tsx (4 hunks)
- apps/native/app/src/screens/home/home.tsx (2 hunks)
- apps/native/app/src/screens/inbox/inbox.tsx (3 hunks)
- apps/native/app/src/screens/more/more.tsx (3 hunks)
- apps/native/app/src/screens/wallet/wallet.tsx (2 hunks)
- apps/native/app/src/utils/get-main-root.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- apps/native/app/src/screens/applications/applications.tsx
Additional context used
Path-based instructions (5)
apps/native/app/src/utils/get-main-root.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/native/app/src/screens/more/more.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/native/app/src/screens/home/home.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/native/app/src/screens/wallet/wallet.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/native/app/src/screens/inbox/inbox.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Biome
apps/native/app/src/screens/inbox/inbox.tsx
[error] 50-50: Shouldn't redeclare 'ListItem'. Consider to delete it or rename it.
'ListItem' is defined here:
(lint/suspicious/noRedeclare)
Additional comments not posted (10)
apps/native/app/src/utils/get-main-root.ts (2)
13-19: Type definition forRightButtonPropslooks good.The addition of the optional
screenproperty is correct and aligns with the function's usage.
20-68:getRightButtonsfunction changes look good.The function correctly handles different screens and returns appropriate button configurations. Ensure that this function is used correctly in all relevant components.
apps/native/app/src/screens/more/more.tsx (2)
37-39: Usage ofgetRightButtonsincreateNavigationOptionHookslooks good.The
screenparameter is correctly set to 'More', aligning with the updated function signature.
76-79: Usage ofgetRightButtonsinuseConnectivityIndicatorlooks good.The
screenparameter is correctly set to 'More', aligning with the updated function signature.apps/native/app/src/screens/home/home.tsx (2)
51-53: Usage ofgetRightButtonsincreateNavigationOptionHookslooks good.The
screenparameter is correctly set to 'Home', aligning with the updated function signature.
115-117: Usage ofgetRightButtonsinuseConnectivityIndicatorlooks good.The
screenparameter is correctly set to 'Home', aligning with the updated function signature.apps/native/app/src/screens/wallet/wallet.tsx (2)
57-59: Usage ofgetRightButtonsincreateNavigationOptionHookslooks good.The
screenparameter is correctly set to 'Wallet', aligning with the updated function signature.
130-132: Usage ofgetRightButtonsinuseConnectivityIndicatorlooks good.The
screenparameter is correctly set to 'Wallet', aligning with the updated function signature.apps/native/app/src/screens/inbox/inbox.tsx (2)
Line range hint
1-1:
Verify the impact of removinggetRightButtons.Ensure that the removal of the
getRightButtonsfunction does not affect the functionality of the navigation bar. Confirm that alternative logic has been implemented to handle the right buttons.Tools
Biome
[error] 50-50: Shouldn't redeclare 'ListItem'. Consider to delete it or rename it.
'ListItem' is defined here:
(lint/suspicious/noRedeclare)
Line range hint
1-1:
Verify the impact of removinguseActiveTabItemPress.Ensure that the removal of the
useActiveTabItemPresshook does not affect the functionality of the tab navigation. Confirm that alternative logic has been implemented to handle tab item press events.Tools
Biome
[error] 50-50: Shouldn't redeclare 'ListItem'. Consider to delete it or rename it.
'ListItem' is defined here:
(lint/suspicious/noRedeclare)
thoreyjona
changed the title
thoreyjona
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- apps/native/app/src/screens/applications/applications.tsx (4 hunks)
- apps/native/app/src/screens/more/more.tsx (3 hunks)
- apps/native/app/src/utils/get-main-root.ts (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- apps/native/app/src/screens/applications/applications.tsx
- apps/native/app/src/screens/more/more.tsx
- apps/native/app/src/utils/get-main-root.ts
…creens should be big (#15478) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
What
Updating nav bar buttons. Only show notification bell on home screen and settings icon on more screen. Move scan icon on wallet screen to be on the right side instead of left.
Why
Simplify nav bar buttons and create space for screen specific buttons when needed.
Screenshots / Gifs
Screen.Recording.2024-07-09.at.11.36.12.mov
Checklist:
Summary by CodeRabbit
New Features
Refactor
Bug Fixes
useActiveTabItemPresslogic to improve performance and code maintainability.