Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth-admin): Webhook for general mandate delegation #16257
base: main
Are you sure you want to change the base?
feat(auth-admin): Webhook for general mandate delegation #16257
Changes from all commits
22fa524
3ed8368
eeb80b0
3f5870f
3671462
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Simplify the
beforeServerStart
function.The
beforeServerStart
function can be simplified. The current implementation wraps the synchronousapp.use
call in an unnecessary Promise. Consider refactoring it as follows:This change maintains the same functionality while making the code more straightforward and easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Enhance test assertions for valid signature scenario.
While the test case correctly checks for a 200 OK response when the signature is valid, it could be improved:
delegationAdminService.createDelegationByZendeskId
was called with the correct parameters.Consider enhancing the test with these additional assertions:
These additions will make the test more robust by ensuring that the service method is called correctly and that the response body matches the expected structure.