fix(web): Syslumenn remove link to fasteignaskra #16276
Conversation
WalkthroughThe pull request introduces changes to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
apps/web/screens/Organization/Syslumenn/Homestay.tsx (1)
278-278: LGTM! Consider removing the unused LinkContext.Provider.The removal of the link to fasteignaskra.is aligns with the PR objective and prevents users from encountering a 404 error. The property ID is still displayed, maintaining the necessary information.
Consider removing the
LinkContext.Providerwrapping this text element, as it's no longer needed for this particular piece of information. This would slightly improve code cleanliness:- <LinkContext.Provider - value={{ - linkRenderer: (href, children) => ( - <a - style={{ - color: theme.color.blue400, - }} - href={href} - rel="noopener noreferrer" - target="_blank" - > - {children} - </a> - ), - }} - > - <Text> - {n('homestayRealEstateNumberPrefix', 'Fasteign nr.')}{' '} - {homestay.propertyId} - </Text> - </LinkContext.Provider> + <Text> + {n('homestayRealEstateNumberPrefix', 'Fasteign nr.')}{' '} + {homestay.propertyId} + </Text>apps/web/screens/Organization/Syslumenn/Auctions.tsx (1)
847-852: LGTM! Consider minor text formatting improvement.The removal of the
LotLinkcomponent for real estate auctions and the addition of a simple text display for the real estate number aligns with the PR objectives. This change effectively addresses the issue of the broken link to fasteignaskra.is.For consistency with other lot types, consider wrapping the real estate number in a
<Text>component on a separate line:{auction.lotId && auction.lotType === LOT_TYPES.REAL_ESTATE && ( - <Text> - {n('auctionRealEstateNumberPrefix', 'Fasteign nr. ')} - {auction.lotId} - </Text> + <Text paddingTop={2} paddingBottom={1}> + {n('auctionRealEstateNumberPrefix', 'Fasteign nr. ')}{auction.lotId} + </Text> )}This change would maintain consistent spacing and styling with other lot type displays.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
- apps/web/screens/Organization/Syslumenn/Auctions.tsx (1 hunks)
- apps/web/screens/Organization/Syslumenn/Homestay.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
apps/web/screens/Organization/Syslumenn/Auctions.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/web/screens/Organization/Syslumenn/Homestay.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (1)
apps/web/screens/Organization/Syslumenn/Auctions.tsx (1)
847-852: Changes look good and address the PR objectivesThe modifications successfully remove the problematic link to fasteignaskra.is for real estate auctions, addressing the main objective of this PR. The implementation is clean, focused, and doesn't introduce any new issues. The changes improve the user experience by preventing navigation to a 404 error page.
Great job on this targeted fix!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16276 +/- ##
==========================================
- Coverage 36.92% 36.92% -0.01%
==========================================
Files 6781 6781
Lines 140031 140040 +9
Branches 39816 39818 +2
==========================================
Hits 51705 51705
- Misses 88326 88335 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed |
Syslumenn remove link to fasteignaskra
What
Remove link to faskeignaskra.is for syslumenn auction and homestay cards.
Why
The link gave 404 on fasteignaskra.is and was not going to change.
Screenshots / Gifs
Homestay before
Homestay after
Auction before
Auction after
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes