Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete takes care of unscheduling; admin validation for scheduled time #20

Closed
wants to merge 10 commits into from

Conversation

bafio
Copy link

@bafio bafio commented Jan 3, 2018

No description provided.

@tom-price
Copy link
Collaborator

I'm closing this request for three reasons

  1. The component where delete takes care of unscheduling was merged in with pr Delete takes care of unscheduling #23
  2. There are cases e.g., disabling a job, where it would be reasonable to save a job with at time in the past. I've looked into raising a warning using Django's Messages framework, but the request is not passed through to the ModelForm so don't think theres a case to build off of this work to achieve that.
  3. Saving a job scheduled in the past doesn't cause it to run immediately.

@tom-price tom-price closed this May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants