Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error on adding Uris in tracklist #26

Open
antoijo opened this issue Mar 20, 2020 · 0 comments · May be fixed by #27
Open

error on adding Uris in tracklist #26

antoijo opened this issue Mar 20, 2020 · 0 comments · May be fixed by #27

Comments

@antoijo
Copy link

antoijo commented Mar 20, 2020

When adding items in trackless with the add function and the Uris parameter. The deprecated parameter uri is still sent and cause an error in Mopidy :

Sent WebSocket message to 127.0.0.1: '{"jsonrpc": "2.0", "id": 1, "error": {"code": -32602, "message": "Invalid params", "data": {"type": "TypeError", "message": "add() got an unexpected keyword argument \'uri\'", "traceback": "Traceback (most recent call last):\\n File \\"/usr/local/Cellar/mopidy/3.0.1/libexec/lib/python3.7/site-packages/mopidy/internal/jsonrpc.py\\", line 131, in _handle_single_request\\n result = self._unwrap_result(result)\\n File \\"/usr/local/Cellar/mopidy/3.0.1/libexec/lib/python3.7/site-packages/mopidy/internal/jsonrpc.py\\", line 228, in _unwrap_result\\n result = result.get()\\n File \\"/usr/local/Cellar/mopidy/3.0.1/libexec/lib/python3.7/site-packages/pykka/_threading.py\\", line 45, in get\\n _compat.reraise(*self._data[\'exc_info\'])\\n File \\"/usr/local/Cellar/mopidy/3.0.1/libexec/lib/python3.7/site-packages/pykka/_compat/__init__.py\\", line 29, in reraise\\n raise value\\n File \\"/usr/local/Cellar/mopidy/3.0.1/libexec/lib/python3.7/site-packages/pykka/_actor.py\\", line 193, in _actor_loop\\n response = self._handle_receive(envelope.message)\\n File \\"/usr/local/Cellar/mopidy/3.0.1/libexec/lib/python3.7/site-packages/pykka/_actor.py\\", line 299, in _handle_receive\\n return callee(*message.args, **message.kwargs)\\nTypeError: add() got an unexpected keyword argument \'uri\'\\n"}}}'

When removing the uri parameter in tracklist.py on line 112 everything works fine.

return self.mopidy_request('core.tracklist.add', tracks=tracks, at_position=at_position, uris=uris, **options)
HarmvZ added a commit to HarmvZ/mopidy-json-client that referenced this issue Oct 19, 2020
@HarmvZ HarmvZ linked a pull request Oct 19, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant