Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/generic notification creation #523

Merged
merged 22 commits into from
Jan 17, 2023
Merged

Feat/generic notification creation #523

merged 22 commits into from
Jan 17, 2023

Commits on Jan 5, 2023

  1. Feat: move notifications router to authenticated subrouter

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    0be51eb View commit details
    Browse the repository at this point in the history

  2. Feat: modify create notification arguments

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    2af5af3 View commit details
    Browse the repository at this point in the history

  3. Feat: add notification middleware to handle edit notifications

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    9ef5f84 View commit details
    Browse the repository at this point in the history

  4. Fix: allow next on routeHandler

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    1f4867d View commit details
    Browse the repository at this point in the history

  5. Feat: add creatnotification middleware to authenticatesSitesRouter

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    ab86b94 View commit details
    Browse the repository at this point in the history

  6. Chore: add notification types

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    280b094 View commit details
    Browse the repository at this point in the history

  7. Feat: add notification changes when reviews are modified

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    5b6c10e View commit details
    Browse the repository at this point in the history

  8. Fix: swap order of subrouters

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    ecf4327 View commit details
    Browse the repository at this point in the history

  9. Fix: review request router dependencies

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    502597d View commit details
    Browse the repository at this point in the history

  10. Fix: time period for updating notification

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    f556f1d View commit details
    Browse the repository at this point in the history

  11. Fix: updating createdAt

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    04db1f9 View commit details
    Browse the repository at this point in the history

  12. Fix: tests

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    737b6bd View commit details
    Browse the repository at this point in the history

  13. Chore: swap to promise.all

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    2916505 View commit details
    Browse the repository at this point in the history

  14. fix: rebase errors

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    406d6bc View commit details
    Browse the repository at this point in the history

  15. Fix: add jsdoc

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    5f51bf1 View commit details
    Browse the repository at this point in the history

  16. Feat: add link to notificationHandler

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    46cde9a View commit details
    Browse the repository at this point in the history

  17. Fix: swap to promise.all and add links

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    20b1c95 View commit details
    Browse the repository at this point in the history

  18. fix(review): fixed triggering event for request approved notif

    @seaerchin @alexanderleegs
    seaerchin authored and alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    8b6d52a View commit details
    Browse the repository at this point in the history

  19. chore(notifications.spec): added correct ports

    @seaerchin @alexanderleegs
    seaerchin authored and alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    eabe6db View commit details
    Browse the repository at this point in the history

  20. Fix: update message on update notification

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    06bc826 View commit details
    Browse the repository at this point in the history

  21. Fix: notification integration tests

    @alexanderleegs
    alexanderleegs committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    c61ae69 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Feat: add generic notification handler tests (#572) 

    * Feat: add generic notification handler tests

* Fix: router initialisation and cleanup

* fix: update github actions to use runInBand

* Fix: update tests

* Fix: reset database tables before integration tests

* Chore: modify imports

* Nit: test comment spelling

Co-authored-by: Kishore <[email protected]>

* Nit: comments and change var names

Co-authored-by: Kishore <[email protected]>
    @alexanderleegs @kishore03109
    alexanderleegs and kishore03109 committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    c90055f View commit details
    Browse the repository at this point in the history