Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add endpoint to mark a review request as viewed #550

Merged
merged 2 commits into from
Oct 31, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions src/routes/v2/authenticated/review.ts
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,70 @@ export class ReviewsRouter {
return res.status(200).json()
}

markReviewRequestAsViewed: RequestHandler<
{ siteName: string; requestId: number },
string | ResponseErrorBody,
never,
unknown,
{ userWithSiteSessionData: UserWithSiteSessionData }
> = async (req, res) => {
// Step 1: Check that the site exists
const { siteName, requestId: prNumber } = req.params
const site = await this.sitesService.getBySiteName(siteName)

if (!site) {
return res.status(404).send({
message: "Please ensure that the site exists!",
})
}

// Step 2: Check that user exists.
// Having session data is proof that this user exists
// as otherwise, they would be rejected by our middleware
const { userWithSiteSessionData } = res.locals

// Check if they are a collaborator
const role = await this.collaboratorsService.getRole(
siteName,
userWithSiteSessionData.isomerUserId
)

if (!role) {
return res.status(400).send({
message: "User is not a collaborator of this site!",
})
}

// Step 3: Retrieve review request
const possibleReviewRequest = await this.reviewRequestService.getReviewRequest(
site,
prNumber
)

if (isIsomerError(possibleReviewRequest)) {
logger.error({
message: "Invalid review request requested",
method: "markReviewRequestAsViewed",
meta: {
userId: userWithSiteSessionData.isomerUserId,
email: userWithSiteSessionData.email,
siteName,
prNumber,
},
})
return res.status(404).json({ message: possibleReviewRequest.message })
}

// Step 4: Mark review request as viewed
await this.reviewRequestService.markReviewRequestAsViewed(
userWithSiteSessionData,
site,
possibleReviewRequest.id
)

return res.status(200).json()
}

getReviewRequest: RequestHandler<
{ siteName: string; requestId: number },
{ reviewRequest: ReviewRequestDto } | ResponseErrorBody,
Expand Down Expand Up @@ -786,6 +850,10 @@ export class ReviewsRouter {
"/:requestId",
attachReadRouteHandlerWrapper(this.getReviewRequest)
)
router.post(
"/:requestId/viewed",
attachWriteRouteHandlerWrapper(this.markReviewRequestAsViewed)
)
router.post(
"/:requestId/merge",
attachWriteRouteHandlerWrapper(this.mergeReviewRequest)
Expand Down
29 changes: 29 additions & 0 deletions src/services/review/ReviewRequestService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,35 @@ export default class ReviewRequestService {
)
}

markReviewRequestAsViewed = async (
sessionData: UserWithSiteSessionData,
site: Site,
requestId: number
): Promise<void> => {
const { isomerUserId: userId } = sessionData

const reviewRequestView = await this.reviewRequestView.findOne({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could we try doing an upsert instead? see here for more details.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I think it might not be possible, because we only want to insert if it is not found. We do not want to perform any updates to the existing entry.

However, I think using upsert would be very useful for updateReviewRequestLastViewedAt, updated that in 927116d.

where: {
siteId: site.id,
userId,
reviewRequestId: requestId,
},
})

// We only want to create the entry if it does not exist
// (i.e. the review request has never been viewed before)
if (!reviewRequestView) {
await this.reviewRequestView.create({
reviewRequestId: requestId,
siteId: site.id,
userId,
// This field represents the user opening the review request
// itself, which the user has not done so yet at this stage.
lastViewedAt: null,
})
}
}

deleteAllReviewRequestViews = async (
site: Site,
pullRequestNumber: number
Expand Down