Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make default empty strings #658

Merged
merged 1 commit into from
Mar 21, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions src/config/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,14 @@ const config = convict({
env: "CLOUDMERSIVE_API_KEY",
sensitive: true,
format: "required-string",
default: null,
default: "",
},
app: {
frontendUrl: {
doc: "URL of the frontend application",
env: "FRONTEND_URL",
format: "required-string",
default: null,
default: "",
},
},
mutexTableName: {
Expand All @@ -87,7 +87,7 @@ const config = convict({
env: "LOCAL_SITE_ACCESS_TOKEN",
sensitive: true,
format: "required-string",
default: null,
default: "",
},
},
auth: {
Expand All @@ -108,14 +108,14 @@ const config = convict({
env: "JWT_SECRET",
sensitive: true,
format: "required-string",
default: null,
default: "",
},
encryptionSecret: {
doc: "Secret used to encrypt access GitHub access token",
env: "ENCRYPTION_SECRET",
sensitive: true,
format: "required-string",
default: null,
default: "",
},
maxNumOtpAttempts: {
doc: "Maximum number of OTP attempts allowed",
Expand Down Expand Up @@ -157,41 +157,41 @@ const config = convict({
env: "AWS_ACCOUNT_NUMBER",
sensitive: true,
format: "required-string",
default: null,
default: "",
},
accessKeyId: {
doc: "AWS access key ID",
env: "AWS_ACCESS_KEY_ID",
sensitive: true,
format: "required-string",
default: null,
default: "",
},
secretAccessKey: {
doc: "AWS secret access key",
env: "AWS_SECRET_ACCESS_KEY",
sensitive: true,
format: "required-string",
default: null,
default: "",
},
},
sqs: {
incomingQueueUrl: {
doc: "URL of the incoming SQS queue",
env: "INCOMING_QUEUE_URL",
format: "required-string",
default: null,
default: "",
},
outgoingQueueUrl: {
doc: "URL of the outgoing SQS queue",
env: "OUTGOING_QUEUE_URL",
format: "required-string",
default: null,
default: "",
},
siteLaunchQueueUrl: {
doc: "URL of the site launch SQS queue",
env: "SITE_LAUNCH_QUEUE_URL",
format: "required-string",
default: null,
default: "",
},
},
},
Expand All @@ -218,20 +218,20 @@ const config = convict({
doc: "GitHub OAuth app Client ID",
env: "CLIENT_ID",
format: "required-string",
default: null,
default: "",
},
clientSecret: {
doc: "GitHub OAuth app Client secret",
env: "CLIENT_SECRET",
sensitive: true,
format: "required-string",
default: null,
default: "",
},
redirectUri: {
doc: "URL to redirect to after authentication with GitHub",
env: "REDIRECT_URI",
format: "required-string",
default: null,
default: "",
},
branchRef: {
doc: "Git branch to use for saving modifications to site",
Expand All @@ -244,7 +244,7 @@ const config = convict({
env: "SYSTEM_GITHUB_TOKEN",
sensitive: true,
format: "required-string",
default: null,
default: "",
},
},
dataDog: {
Expand All @@ -258,13 +258,13 @@ const config = convict({
doc: "The DataDog service",
env: "DD_SERVICE",
format: "required-string",
default: null,
default: "",
},
tags: {
doc: "The DataDog tags",
env: "DD_TAGS",
format: "required-string",
default: null,
default: "",
},
},
formSg: {
Expand Down Expand Up @@ -303,15 +303,15 @@ const config = convict({
env: "E2E_TEST_SECRET",
sensitive: true,
format: "required-string",
default: null,
default: "",
},
e2eTestGithubToken: {
doc:
"GitHub access token for e2e tests. Replace with your own token and make sure the github user is in your local database",
env: "E2E_TEST_GH_TOKEN",
sensitive: true,
format: "required-string",
default: null,
default: "",
},
},
database: {
Expand Down