Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lifecycle and an output #102

Merged
merged 2 commits into from
Jun 10, 2024
Merged

A lifecycle and an output #102

merged 2 commits into from
Jun 10, 2024

Conversation

littlejo
Copy link
Contributor

@littlejo littlejo commented Jun 7, 2024

Hello,

I need kubeconfig output (content of kubeconfig). Kubeconfig change every apply. So i propose a lifecycle on this to prevent a recreation at each time. And nonsensitive is useless.

I test this on: https://github.com/tf-cilium/terraform-aws-talos-cilium

@PhilipSchmid PhilipSchmid added the enhancement New feature or request label Jun 7, 2024
Copy link
Collaborator

@PhilipSchmid PhilipSchmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make docs and amend the README.md changes. Other than this, LGTM. Thanks!

@PhilipSchmid PhilipSchmid merged commit 8c1c0c6 into isovalent:main Jun 10, 2024
1 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants