test: use the first five chars of md5sum of unique workflow run ident… #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyp1ckles
force-pushed
the
pr/tp/fix-naming-collisions
branch
3 times, most recently
from
cf376ec
to
1001a79
Compare
tommyp1ckles
force-pushed
the
pr/tp/fix-naming-collisions
branch
from
1001a79
to
f4c6d7a
Compare
tommyp1ckles
force-pushed
the
pr/tp/fix-naming-collisions
branch
from
3c6fff4
to
baf303c
Compare
…ifier. The tuple (repo, run_id, run_attempt) identifies a run, however this is too long for the terraform talos name. So we use this to generate a 5-digit hash instead of using random 3 digit ids which are prone to collisions. Signed-off-by: Tom Hadlaw <[email protected]>
tommyp1ckles
force-pushed
the
pr/tp/fix-naming-collisions
branch
from
baf303c
to
0331145
Compare
PhilipSchmid
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tuple (repo, run_id, run_attempt) identifies a workflow run, however this is too long for the terraform talos name. So we use this to generate a 5-digit hash instead of using random 3 digit ids which are prone to collisions.