.github: conformance: use matrix.config.name. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyp1ckles
force-pushed
the
pr/tp/use-correct-name-field
branch
from
8cbb7a9
to
abbc1aa
Compare
As well, tag resources with test name, cilium version and url to github workflow. This will help us trace back where some of these leaked/uncleaned vpcs are coming from. Signed-off-by: Tom Hadlaw <[email protected]>
tommyp1ckles
force-pushed
the
pr/tp/use-correct-name-field
branch
from
abbc1aa
to
abae00d
Compare
PhilipSchmid
approved these changes
May 8, 2024
There was a problem hiding this comment.
Thanks a lot!
It perhaps failed before because of the ${{ matrix.name }} value, which wasn't correctly parsed (maybe because it has spaces in it?). For example, by having a look at the raw log outputs from failed tasks from https://github.com/isovalent/terraform-aws-talos/actions/runs/8875975603/, we can see --pr looked like this:
2024-04-29T09:02:12.3657830Z �[36;1m --pr "terraform-aws-talos-8875975603-166-1--v1.15.1-v1.6.5" \�[0m
2024-04-29T09:02:08.8963522Z �[36;1m --pr "terraform-aws-talos-8875975603-166-1--v1.15.1-v1.6.5" \�[0m
2024-04-29T09:06:22.3607777Z �[36;1m --pr "terraform-aws-talos-8875975603-166-1--v1.15.1-v1.5.4" \�[0m
There we see -- which means ${{ matrix.name }}, which should be in between those -, was empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old VPCs/LBs are not being cleaned up, and I can't figure out what jobs they're failing on. So this refactors the create test env script a bit to pass run id/number as well as cilium_version and test_name separately, then we can write these to the test infra tags to help us figure out what cloud resources belong to what test run.
As well, the naming is still failing so I'm going to just do
md5sum($run_id-$run_number-$random)to (hopefully) make it extremely unlikely of a collision.