Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waiting for tmp1 until it's available #43

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

liyihuang
Copy link
Contributor

trying to resolve this issue #42

@liyihuang liyihuang requested a review from a team as a code owner June 27, 2024 18:21
Copy link
Contributor

@PhilipSchmid PhilipSchmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates an endless loop in case the tmp1 never gets created (for whatever reason), no? How about adding a max timeout?

@liyihuang
Copy link
Contributor Author

I thought about the timeout. However, we need the tmp1 for the helm install. if it just times out, we will get the error from the helm install. or I can just simply put like a sleep 5 or sleep 10 to let helm to throw the error.

Copy link
Contributor

@PhilipSchmid PhilipSchmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, valid point. Thanks!

@liyihuang liyihuang merged commit 4dd6797 into main Jun 27, 2024
2 checks passed
@liyihuang liyihuang deleted the pr/liyihuang/wait-for-tmp1 branch June 27, 2024 20:20
@liyihuang liyihuang restored the pr/liyihuang/wait-for-tmp1 branch June 29, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants