Update comments in Dockerfile #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are now installed during aiidalab-ispg install, see ispg-group/aiidalab-ispg#221
danielhollas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are now installed during aiidalab-ispg install, see ispg-group/aiidalab-ispg#221
NOTE: We can't merge this until we publish a new aiidalab-ispg version. And I think also we should only merge this once we put aiidalab-ispg in the aiidalab App repository so that users can update easily if needed since this is a breaking change.EDIT: I decided to keep OpenMPI and xtb installation here to speed up the app installation.