Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two types of name conventions of classes appear:
snake_case
andCamelCase
.This PR chooses
CamelCase
because PEP8 recommends it.While abICS v2, we also offer the old names as aliases for the backward compatibility.
abics.mc
model
->Model
observer_base
->ObserverBase
grid_1D
->Grid1D
abics.applications.latgas_abinitio_interface.default_observer
default_observer
->DefaultObserver
ensemble_error_observer
->EnsembleErrorObserver
abics.applications.latgas_abinitio_interface.model_setup
dft_latgas
->DFTLatticeGas
energy_lst
->EnergyList
group
->Group
defect_sublattice
->DefectSublattice
config
->Config
abics.applications.latgas_abinitio_interface.run_base_mpi
runner
->Runner
runner_multistep
->RunnerMultistep
runner_ensemble
->RunnerEnsemble
run_mpispawn
->RunMpispawn
run_mpispawn_ready
->RunMpispawnReady
run_mpispawn_wrapper
->RunMpispawnWrapper
run_subprocess
->RunSubprocess
run_function
->RunFunction