Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change class names #45

Merged
merged 4 commits into from
Aug 26, 2022
Merged

change class names #45

merged 4 commits into from
Aug 26, 2022

Conversation

yomichi
Copy link
Contributor

@yomichi yomichi commented Aug 26, 2022

Two types of name conventions of classes appear: snake_case and CamelCase.
This PR chooses CamelCase because PEP8 recommends it.
While abICS v2, we also offer the old names as aliases for the backward compatibility.

  • abics.mc
    • model -> Model
    • observer_base -> ObserverBase
    • grid_1D -> Grid1D
  • abics.applications.latgas_abinitio_interface.default_observer
    • default_observer -> DefaultObserver
    • ensemble_error_observer -> EnsembleErrorObserver
  • abics.applications.latgas_abinitio_interface.model_setup
    • dft_latgas -> DFTLatticeGas
    • energy_lst -> EnergyList
    • group -> Group
    • defect_sublattice -> DefectSublattice
    • config -> Config
  • abics.applications.latgas_abinitio_interface.run_base_mpi
    • runner -> Runner
    • runner_multistep -> RunnerMultistep
    • runner_ensemble -> RunnerEnsemble
    • run_mpispawn -> RunMpispawn
    • run_mpispawn_ready -> RunMpispawnReady
    • run_mpispawn_wrapper -> RunMpispawnWrapper
    • run_subprocess -> RunSubprocess
    • run_function -> RunFunction

@yomichi yomichi merged commit a75397a into develop Aug 26, 2022
@yomichi yomichi deleted the class_structure branch September 22, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant