Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Node.js 6, add support for filenamePrefix callback #13

Merged
merged 2 commits into from
May 9, 2019
Merged

Drop Node.js 6, add support for filenamePrefix callback #13

merged 2 commits into from
May 9, 2019

Conversation

coreyfarrell
Copy link
Member

Fixes #4

I'm open to suggestions for a different name to filenamePrefix.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 57

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 56: 0.0%
Covered Lines: 43
Relevant Lines: 43
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented May 6, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 57

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 56: 0.0%
Covered Lines: 43
Relevant Lines: 43
💛 - Coveralls

@coreyfarrell coreyfarrell requested review from JaKXz and bcoe May 9, 2019 12:49
@coreyfarrell coreyfarrell mentioned this pull request May 9, 2019
Closed
13 tasks
@coreyfarrell coreyfarrell merged commit 9b685fe into istanbuljs:master May 9, 2019
@coreyfarrell coreyfarrell deleted the node8 branch May 9, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@JaKXz JaKXz Awaiting requested review from JaKXz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefix with original file name
3 participants
@coreyfarrell @coveralls @bcoe